uno.check icon indicating copy to clipboard operation
uno.check copied to clipboard

fix: JDK checks on macOS

Open Cheesebaron opened this issue 4 months ago โ€ข 1 comments

GitHub Issue: closes # Fixes #463

PR Type:

  • ๐Ÿž Bugfix

What is the current behavior? ๐Ÿค”

  • Uno.Check has hardcoded path on macOS to look for microsoft-11 JDK distribution
  • It checks folder Library/Java/JavaVirtualMachines but should be /Library/Java/JavaVirtualMachines
  • Only checks for microsoft and openjdk distributions
    • This wouldn't allow me to use temurin which I have installed

What is the new behavior? ๐Ÿš€

  • Removed hardcoded microsoft-11 path
  • Check correct /Library/Java/JavaVirtualMachines folder for installed JDKs
  • Added temurin, zulu and corretto as allowed JDKs too (perhaps all open JDK distributions should be allowed?)

PR Checklist โœ…

Please check if your PR fulfills the following requirements:

Other information โ„น๏ธ

Cheesebaron avatar Oct 23 '25 08:10 Cheesebaron

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 23 '25 08:10 CLAassistant