uno.check
uno.check copied to clipboard
fix: JDK checks on macOS
GitHub Issue: closes # Fixes #463
PR Type:
- ๐ Bugfix
What is the current behavior? ๐ค
- Uno.Check has hardcoded path on macOS to look for microsoft-11 JDK distribution
- It checks folder
Library/Java/JavaVirtualMachinesbut should be/Library/Java/JavaVirtualMachines - Only checks for
microsoftandopenjdkdistributions- This wouldn't allow me to use
temurinwhich I have installed
- This wouldn't allow me to use
What is the new behavior? ๐
- Removed hardcoded microsoft-11 path
- Check correct
/Library/Java/JavaVirtualMachinesfolder for installed JDKs - Added
temurin,zuluandcorrettoas allowed JDKs too (perhaps all open JDK distributions should be allowed?)
PR Checklist โ
Please check if your PR fulfills the following requirements:
- [x] ๐ Commits must be following the Conventional Commits specification.
- [ ] ๐งช Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
- [ ] ๐ Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] ๐ผ๏ธ Validated PR
Screenshots Compare Test Runresults. - [x] โ Contains NO breaking changes