uno.check
uno.check copied to clipboard
fix(Target): Add desktop and winSdk flag to recognized Targets
GitHub Issue: closes #404,
Partially/maybe solving: #352
PR Type:
- ๐ Bugfix
What is the current behavior? ๐ค
the target flag does not recognize these values, while these are the ones the extension
What is the new behavior? ๐
As I am not able to test the actual extension, this only applyes on the CLI itself from the code!
added the cases for the GetTargetPlatformFromFlag(targetFlag) which is called in:
https://github.com/unoplatform/uno.check/blob/035335d2e4913efaa848232aef21362ff78f640b/UnoCheck/Checkups/VSWinWorkloadsCheckup.cs#L41-L54
and:
https://github.com/unoplatform/uno.check/blob/0595b3bbdfc9c29bb4fcabc38d1b7b95c2ac45bb/UnoCheck/TargetPlatformHelper.cs#L11-L26
PR Checklist โ
Please check if your PR fulfills the following requirements:
- [x] ๐ Commits must be following the Conventional Commits specification.
- [ ] ๐งช Added Runtime tests, UI tests, or a manual test sample for the changes have been added (for bug fixes / features) (if applicable)
- [ ] ๐ Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] ๐ผ๏ธ Validated PR
Screenshots Compare Test Runresults. - [x] โ Contains NO breaking changes