uno.check icon indicating copy to clipboard operation
uno.check copied to clipboard

fix(Target): Add desktop and winSdk flag to recognized Targets

Open DevTKSS opened this issue 8 months ago โ€ข 0 comments

GitHub Issue: closes #404,

Partially/maybe solving: #352

PR Type:

  • ๐Ÿž Bugfix

What is the current behavior? ๐Ÿค”

the target flag does not recognize these values, while these are the ones the extension

What is the new behavior? ๐Ÿš€

As I am not able to test the actual extension, this only applyes on the CLI itself from the code! added the cases for the GetTargetPlatformFromFlag(targetFlag) which is called in:

https://github.com/unoplatform/uno.check/blob/035335d2e4913efaa848232aef21362ff78f640b/UnoCheck/Checkups/VSWinWorkloadsCheckup.cs#L41-L54

and:

https://github.com/unoplatform/uno.check/blob/0595b3bbdfc9c29bb4fcabc38d1b7b95c2ac45bb/UnoCheck/TargetPlatformHelper.cs#L11-L26

PR Checklist โœ…

Please check if your PR fulfills the following requirements:

Other information โ„น๏ธ

DevTKSS avatar Jun 28 '25 14:06 DevTKSS