Uno.Themes icon indicating copy to clipboard operation
Uno.Themes copied to clipboard

Published 20 hours ago • verified publisher icon unoplatform

[All][TextBox] Placeholder Text not Vertically Centered

Open Soap-141 opened this issue 2 years ago • 5 comments

Current behavior

When using a TextBox with MaterialOutlineTextBoxStyle the placeholder text is not vertically centered.

Capture_97

Expected behavior

When using a TextBox with MaterialOutlineTextBoxStyle the placeholder text should be vertically centered.

How to reproduce it (as minimally and precisely as possible)

  1. Download MyApp.zip
  2. Open solution
  3. Start project
  4. Notice Placeholder Text in the TextBox is not vertically centered

Environment

Nuget Package:

  • Uno.WinUI
  • Uno.Material.WinUI

Package Version(s):

  • 4.5.0-dev.802
  • 2.3.0-dev.12

Affected platform(s):

  • [x] iOS
  • [x] Android
  • [ ] ~~WebAssembly~~
  • [ ] ~~UWP~~
  • [x] WinUI
  • [ ] ~~MacOS~~

Anything else we need to know?

Soap-141 avatar Sep 07 '22 13:09 Soap-141

Not fixed in 2.3.0-dev.20 image

Soap-141 avatar Sep 12 '22 12:09 Soap-141

Syncing with @Soap-141 at the moment to make sure of the nuget package version and the sample app he used for his tests

agneszitte avatar Sep 12 '22 15:09 agneszitte

So after syncing with @Soap-141 regarding the vertical alignment issue for the TextBox, Thomas did a sample app but there were no font files added to the sample so it was using the default font.

Uno.Themes for Material is using Roboto font and the project is using EncodeSansCondensed font.

So I'm trying to make sure placeholder and editable text are properly vertically aligned in the style regarding what font is used at the end

agneszitte avatar Sep 12 '22 19:09 agneszitte

@jeromelaban, @kazo0 with all of the changes for the fonts lately I'm not sure if this issue is still relevant What should we do next for this one?

agneszitte avatar Jan 26 '23 22:01 agneszitte

should be covered within #974

Xiaoy312 avatar May 27 '23 15:05 Xiaoy312

@jhanvi03 I will let you verify the Material TextBox (that you can test with Gallery Canary) to see if we still have some vertical alignment issues please. If so please leave more details for the impacted platforms. If not we can close this issue.

agneszitte avatar Jul 12 '24 21:07 agneszitte

Text seems to be align on iOS, Android and WinUI. image

I have opened another issue for Icon not align with the text https://github.com/unoplatform/Uno.Themes/issues/1443

jhanvi03 avatar Jul 15 '24 14:07 jhanvi03

Text seems to be align on iOS, Android and WinUI.

I have opened another issue for Icon not align with the text #1443

Thanks @jhanvi03! I am closing this issue then, and we will use https://github.com/unoplatform/Uno.Themes/issues/1443 to track the alignment issue when there is an icon.

agneszitte avatar Jul 15 '24 19:07 agneszitte