Uno.Themes icon indicating copy to clipboard operation
Uno.Themes copied to clipboard

Published 20 hours ago • verified publisher icon unoplatform

Feat: ModalBottomSheet

Open NicolasChampagne opened this issue 3 years ago • 1 comments

GitHub Issue: #399

PR Type

What kind of change does this PR introduce?

  • Feature

Description

  • New Feature

PR Checklist

Please check if your PR fulfills the following requirements:

  • Commits must be following the Conventional Commits specification
  • [x] Tested UWP
  • [x] Tested iOS
  • [x] Tested Android
  • [x] Tested WASM
  • [ ] Tested MacOS
  • [x] Contains No breaking changes

    If the pull request contains breaking changes, commit message must contain a detailed description of the action to take for the consumer of this library. As explained by the Conventional Commits specification

Other information

Internal Issue (If applicable):

NicolasChampagne avatar Sep 04 '20 19:09 NicolasChampagne

I believe almost all of the changes which were part of this PR are by now merged into master, except very minor changes in StandardBottomSheet (removing <ResourceDictionary Source="../Controls/FloatingActionButton.xaml" />) and ToggleButton.xaml (removing <CornerRadius x:Key="ExpandingBottomSheetToggleButtonBorderRadius">22,0,0,0</CornerRadius>. @NicolasChampagne could we close this pull request?

juliecantin avatar Sep 25 '20 15:09 juliecantin

This PR has been up for many years without any update. Functionally, Sheet has been reimplemented as DrawerControl and DrawerFlyout in Uno.Toolkit. So I am closing this now.

Xiaoy312 avatar Sep 29 '22 17:09 Xiaoy312