Uno.Themes icon indicating copy to clipboard operation
Uno.Themes copied to clipboard

Include word is used Two times.

Open Darsh0307 opened this issue 1 year ago • 5 comments

On which page?

https://platform.uno/docs/articles/external/uno.themes/doc/themes-overview.html

Screenshot 2023-11-06 at 10 46 42 AM

What's wrong?

The "Include" word is used Twice

Any feedback?

I think that changing the line to "Both libraries help you style your application with just a few lines of code, including:" will make more sense

Darsh0307 avatar Nov 06 '23 15:11 Darsh0307

Hi! I might be able to find where the double word is coming from and delete it. I can take a look. I am a first-timer contributor still learning.

sfazli96 avatar Nov 07 '23 04:11 sfazli96

Hi! I might be able to find where the double word is coming from and delete it. I can take a look. I am a first-timer contributor still learning.

Hi @sfazli96 welcome! We will happily accept your contribution to this issue. Here is our Contribution Guide for all the details. As it is detailed in it, your commit must be in the Conventional Commits format please.

Here is the updated sentence that we should have in this case instead: Both libraries help you style your application with a few lines of code, including:

And here is the current related code: https://github.com/unoplatform/Uno.Themes/blob/52d545d39ed086c10151fd80c95518a776171abb/doc/themes-overview.md?plain=1#L21

Please let us know if you have any additional questions or blockers and we will be happy to help you!

agneszitte avatar Nov 08 '23 16:11 agneszitte

Ok I made a pull request and fixed the wording.

sfazli96 avatar Nov 08 '23 20:11 sfazli96

Ok I made a pull request and fixed the wording.

Thank you a lot for your PR @sfazli96, it is really appreciated! I left you a comment https://github.com/unoplatform/Uno.Themes/pull/1279#issuecomment-1802713245

agneszitte avatar Nov 08 '23 21:11 agneszitte

yeah I saw the comment and updated the title.

sfazli96 avatar Nov 12 '23 00:11 sfazli96

CC @agneszitte, @Darsh0307 Closing this issue as it was fixed by https://github.com/unoplatform/Uno.Themes/pull/1308

morning4coffe-dev avatar Jun 29 '24 13:06 morning4coffe-dev