Uno.Themes icon indicating copy to clipboard operation
Uno.Themes copied to clipboard

Published 20 hours ago • verified publisher icon unoplatform

feat(navigationview): Add lightweight styling to navigation view styles

Open nguyeenvy opened this issue 1 year ago • 5 comments

GitHub Issue: https://github.com/unoplatform/uno.themes-private/issues/5

PR Type

What kind of change does this PR introduce?

  • Feature

Description

PR Checklist

  • [X] Tested UWP
  • [ ] Tested iOS
  • [ ] Tested Android
  • [X] Tested WASM
  • [ ] Tested MacOS
  • [X] Contains No breaking changes

Other information

Internal Issue (If applicable):

nguyeenvy avatar Jul 12 '23 19:07 nguyeenvy

Waiting for PR https://github.com/unoplatform/Uno.Themes/pull/1106 to merge before updating this PR.

nguyeenvy avatar Jul 26 '23 19:07 nguyeenvy

@kazo0 Is this ready for review? I don't see any comments on the changed files and pr #1106 was merged. Do you know what's missing here? Thanks!

silviuo avatar Sep 26 '23 18:09 silviuo

@silviuo I kept this one for last because I knew it'd be big and then I forgot :) but there will be comments from what I see here. Will look it over now

kazo0 avatar Sep 26 '23 19:09 kazo0

I rebased off latest master and refactored resource values to keys

silviuo avatar Sep 28 '23 15:09 silviuo

Let's revisit if this PR is still needed after @Xiaoy312 current work with a script

agneszitte avatar Oct 06 '23 17:10 agneszitte