Uno.Samples icon indicating copy to clipboard operation
Uno.Samples copied to clipboard

feat: SingleProject - Commerce

Open vatsashah45 opened this issue 2 years ago • 4 comments

vatsashah45 avatar Mar 22 '24 03:03 vatsashah45

Sample updated with latest template.

Known issues so far:

  1. WinAppSDK and Android The app uses the file products.json to store the products info. This file lives in the project root directory, but this file is not found by the code when trying to load the products. It only worked for Windows Packaged when I moved the file to Assets. But it didn't work for Android nor Windows Unpackaged.

  2. When running the app on Desktop no window is launched. Nothing really happens.

  3. On WASM the app is launched, but just a black screen is shown.

I know there are more issues related to loading data. I will post them later after I test it more.

erikvilima avatar Mar 26 '24 18:03 erikvilima

We're currently facing this issue on this app - https://github.com/unoplatform/uno/issues/16430

erikvilima avatar Apr 23 '24 18:04 erikvilima

We're currently facing this issue on this app - unoplatform/uno#16430

@eriklimakc, @vatsashah45 now that https://github.com/unoplatform/uno/issues/16430 is closed, are there any issues left to finish the migration, please? (cc @nickrandolph)

agneszitte avatar May 10 '24 17:05 agneszitte

@eriklimakc, @vatsashah45 now that unoplatform/uno#16430 is closed, are there any issues left to finish the migration, please? (cc @nickrandolph)

Yes, I don't see the build error anymore, so that's fixed. But I see a regression, the Uno.Extensions.Storage.FileStorage issue (https://github.com/unoplatform/uno-private/issues/408) is back only on wasm, and that prevents products from loading:

image

cc @agneszitte @jeromelaban @nickrandolph

erikvilima avatar May 10 '24 17:05 erikvilima

With latest packages the warnings for everything related to appsettings still appear on Wasm and other platforms: image

However, the products.json file does not appear in the warnings. In fact, all the products are loaded and all feeds with products are working as expected.

cc: @agneszitte

rajamatt avatar May 29 '24 14:05 rajamatt

Favorites

All items are favorited by default but they don't appear in the Favorites feed, we have to unfavorite them and favorite them again for them to appear in the Favorites feed.

Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/737

rajamatt avatar May 29 '24 14:05 rajamatt

Cart

  • Quantity of items in the cart can't be changed, the "More" and "Less" commands are never bound to in the Xaml
  • Items can't be removed from the cart because the "Remove" command is never bound to in the Xaml

https://github.com/unoplatform/Uno.Samples/blob/bc7377700aae3c1721283b8ed8890bffda051903/reference/Commerce/src/Commerce/Presentation/CartViewModel.cs#L7-L14

  • Number of items in cart is hardcoded

https://github.com/unoplatform/Uno.Samples/blob/bc7377700aae3c1721283b8ed8890bffda051903/reference/Commerce/src/Commerce/Views/CartPage.xaml#L34


Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/738

rajamatt avatar May 29 '24 14:05 rajamatt

ProductsPage (search page)

  • The "Products found" count is hardcoded https://github.com/unoplatform/Uno.Samples/blob/bc7377700aae3c1721283b8ed8890bffda051903/reference/Commerce/src/Commerce/Views/ProductsPage.xaml#L66 Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/739

  • Searching for products only works if a filter is selected first

  • Clicking on an item in the Search doesn't do anything (should it?) Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/740

rajamatt avatar May 29 '24 14:05 rajamatt

Miscellaneous

  • About 1/5 of the time, navigating to the profile page causes a COMException (I think its because the profile pictures are random and one of them might be problematic but I'm not sure) Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/741 image

  • [x] Back buttons aren't visible but are functional (not sure if it's theming related or not) ** Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/742** image

  • The left hand navbar's items could be spaced a bit better (they are very close together and the focus background stacks on adjacent items) Related issue opened: https://github.com/unoplatform/Uno.Samples/issues/743 image

rajamatt avatar May 29 '24 14:05 rajamatt

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

kazo0 avatar Jun 04 '24 19:06 kazo0

Another related issue opened: [Commerce] Images are too large #735

agneszitte avatar Jun 05 '24 00:06 agneszitte

@rajamatt can you create separate issues for those things you've noticed. And I can also reproduce them on current master so it doesnt seem to be related to this pr

Done

rajamatt avatar Jun 05 '24 13:06 rajamatt