Uno.Gallery
Uno.Gallery copied to clipboard
feat: SwipeControl samples
GitHub Issue (If applicable): https://github.com/unoplatform/uno/issues/6894
PR Type
What kind of change does this PR introduce?
- Feature
What is the current behavior?
No samples for SwipeControl
What is the new behavior?
Add samples for SwipeControl which are adapted from Microsoft's XCG source
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Tested on iOS.
- [ ] Tested on Wasm.
- [x] Tested on Android.
- [x] Tested on UWP.
- [x] Tested in both Light and Dark themes.
- [x] Associated with an issue (GitHub or internal)
Other information
FYI: I tested these samples and SwipeControl doesn't seem to work correctly on WASM.
Internal Issue (If applicable): N/A
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/cc @agneszitte-nventive @dr1rrb
@jeromelaban / @dr1rrb / @duke7553 the samples will be just for fluent ?
@agneszitte-nventive Do we have other themes for SwipeControl besides Fluent?
@jeromelaban / @dr1rrb / @duke7553 the samples will be just for fluent ?
Well I would assume that we could do the sample for all themes. And except the border brush, I would assume that the SwipeControl
would be almost the same for all themes.
@jeromelaban is it possible to enable azure static webapps PR validation for Uno.Gallery?
@jeromelaban is it possible to enable azure static webapps PR validation for Uno.Gallery?
I made a PR to enable Azure Static WebApps: https://github.com/unoplatform/Uno.Gallery/pull/282
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@kazo0 , @jeromelaban , @MartinZikmund , @dr1rrb , @lukeblevins Status on this older PR ? (Was quickly doing some cleanup on my GitHub notifications this morning ;) )
@kazo0 , @jeromelaban , @MartinZikmund , @dr1rrb , @lukeblevins
Status on this older PR ? (Was quickly doing some cleanup on my GitHub notifications this morning ;) )
I would merge as is and if needed we will apply changes later.
Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
Merci beaucoup 👋