Uno.Gallery icon indicating copy to clipboard operation
Uno.Gallery copied to clipboard

feat: SwipeControl samples

Open lukeblevins opened this issue 2 years ago • 12 comments

GitHub Issue (If applicable): https://github.com/unoplatform/uno/issues/6894

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No samples for SwipeControl

What is the new behavior?

Add samples for SwipeControl which are adapted from Microsoft's XCG source

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tested on iOS.
  • [ ] Tested on Wasm.
  • [x] Tested on Android.
  • [x] Tested on UWP.
  • [x] Tested in both Light and Dark themes.
  • [x] Associated with an issue (GitHub or internal)

Other information

FYI: I tested these samples and SwipeControl doesn't seem to work correctly on WASM.

Internal Issue (If applicable): N/A

lukeblevins avatar Sep 02 '21 01:09 lukeblevins

/azp run

jeromelaban avatar Sep 02 '21 12:09 jeromelaban

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 02 '21 12:09 azure-pipelines[bot]

/cc @agneszitte-nventive @dr1rrb

jeromelaban avatar Sep 02 '21 12:09 jeromelaban

@jeromelaban / @dr1rrb / @duke7553 the samples will be just for fluent ?

agneszitte avatar Sep 02 '21 13:09 agneszitte

@agneszitte-nventive Do we have other themes for SwipeControl besides Fluent?

lukeblevins avatar Sep 02 '21 15:09 lukeblevins

@jeromelaban / @dr1rrb / @duke7553 the samples will be just for fluent ?

Well I would assume that we could do the sample for all themes. And except the border brush, I would assume that the SwipeControl would be almost the same for all themes.

dr1rrb avatar Sep 02 '21 15:09 dr1rrb

@jeromelaban is it possible to enable azure static webapps PR validation for Uno.Gallery?

agneszitte avatar Sep 02 '21 16:09 agneszitte

@jeromelaban is it possible to enable azure static webapps PR validation for Uno.Gallery?

I made a PR to enable Azure Static WebApps: https://github.com/unoplatform/Uno.Gallery/pull/282

agneszitte avatar Sep 08 '21 00:09 agneszitte

/azp run

agneszitte avatar Sep 08 '21 22:09 agneszitte

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 08 '21 22:09 azure-pipelines[bot]

/azp run

kazo0 avatar Oct 12 '21 13:10 kazo0

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 12 '21 13:10 azure-pipelines[bot]

@kazo0 , @jeromelaban , @MartinZikmund , @dr1rrb , @lukeblevins Status on this older PR ? (Was quickly doing some cleanup on my GitHub notifications this morning ;) )

agneszitte avatar Jan 12 '23 16:01 agneszitte

@kazo0 , @jeromelaban , @MartinZikmund , @dr1rrb , @lukeblevins

Status on this older PR ? (Was quickly doing some cleanup on my GitHub notifications this morning ;) )

I would merge as is and if needed we will apply changes later.

dr1rrb avatar Jan 12 '23 23:01 dr1rrb

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

welcome[bot] avatar Jan 13 '23 12:01 welcome[bot]