unlock icon indicating copy to clipboard operation
unlock copied to clipboard

feat(key): ethpass integration - draft

Open christopherdro opened this issue 2 years ago • 1 comments

christopherdro avatar Aug 17 '22 14:08 christopherdro

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @christopherdro on file. In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot. Thank you!

cla-bot[bot] avatar Aug 17 '22 14:08 cla-bot[bot]

Awesome! Thanks a lot @christopherdro ! I will look at this week!

julien51 avatar Feb 13 '23 14:02 julien51

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @christopherdro on file. In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the the file .clabot. Thank you!

cla-bot[bot] avatar Feb 16 '23 02:02 cla-bot[bot]

@searchableguy Please take a look if you can! I will add the same buttons to add to wallet on the final checkout step tomorrow... but would love it if you could already give a look!

julien51 avatar Feb 16 '23 02:02 julien51

Screenshots: Screenshot 2023-02-17 at 11 27 09 AM

Screenshot 2023-02-17 at 11 28 11 AM Screenshot 2023-02-17 at 11 28 41 AM

julien51 avatar Feb 17 '23 16:02 julien51

Can we use the same style we use for other like open in Keychain for the add to buttons?

It looks out of place here.

searchableguy avatar Feb 17 '23 16:02 searchableguy

Can we use the same style we use for other like open in Keychain for the add to buttons?

Let me ping Chiali on that. That said I want to distinguish buttons and links

julien51 avatar Feb 17 '23 16:02 julien51

Screenshot 2023-02-17 at 2 12 49 PM Maybe this is a bit better

julien51 avatar Feb 17 '23 19:02 julien51

I like it. Please also handle the situation where it is on small screen (make them stack instead of grid).

searchableguy avatar Feb 17 '23 22:02 searchableguy

I like it. Please also handle the situation where it is on small screen (make them stack instead of grid).

Very good point! Let me check.

julien51 avatar Feb 17 '23 23:02 julien51