unlock icon indicating copy to clipboard operation
unlock copied to clipboard

Maintain compatibility with old lock versions

Open searchableguy opened this issue 2 years ago • 3 comments

Describe the bug Current checkout isn't well tested and may have edge or bugs which appear on locks older than v10 due to previous lock not supporting multiple memberships.

We should test on previous locks and make fixes for backward compatibility.

searchableguy avatar Jul 15 '22 17:07 searchableguy

I think it would be good to have a script to identity the list of locks (+versions) that have sold at least one membership in a given time frame for all networks. This should use the subgraph. I think it is safe to remove support (at least one the checkout... but probably at the UnlockJS level) for anything that has not sold a membership in 1 year. wdyt?

julien51 avatar Jul 22 '22 12:07 julien51

I think 6 months would be reasonable. Since from v9, it's upgradable so would be minimal disruption. We could show an error - you need to upgrade lock in the checkout if we find it's not compatible and ask user to upgrade.

searchableguy avatar Jul 28 '22 20:07 searchableguy

We could show an error - you need to upgrade lock in the checkout if we find it's not compatible and ask user to upgrade.

Absolutely. I expect we will add an explicit way to upgrade on the new dashboard.

julien51 avatar Jul 29 '22 07:07 julien51

The issue can be closed because we already test with v9 (our own lock for members). For below, we don't have any active locks so testing with them is not useful.

searchableguy avatar Sep 23 '22 18:09 searchableguy