unlock icon indicating copy to clipboard operation
unlock copied to clipboard

Convert unlock-asset package to typescript

Open searchableguy opened this issue 2 years ago • 3 comments

Is your feature request related to a problem? Please describe. Types are missing from unlock-assets package because we haven't set up svgr to generate ts files instead of js for svg components.

Describe the solution you'd like Add typescript support by modifying the template and package.

searchableguy avatar May 23 '22 13:05 searchableguy

Maybe @m00n620 might be interested :)

julien51 avatar Jun 20 '22 20:06 julien51

Hey, I was playing around with this a little and it seems the SVGR CLI tool has some weird compatibility issues with typescript. I am only able to get the generated components to be typescript files. Couldn't find a solution to convert the actual template file and the rest into typescript.

Let me know if just generating the ts files has some value, or if the whole package needs to be typescript as well.

jordang7 avatar Aug 05 '22 17:08 jordang7

Only the former.

searchableguy avatar Aug 05 '22 18:08 searchableguy

Closing as this was done! I;ll pay the 500 DAI bounty this week!

julien51 avatar Oct 05 '22 17:10 julien51