unlock icon indicating copy to clipboard operation
unlock copied to clipboard

feat(smart-contracts): add `hasRole` hook

Open clemsos opened this issue 1 year ago • 1 comments

Description

Add a hook for role management, so a third party contract can manage roles independently

Issues

Fixes #14562 Refs #

Checklist:

  • [ ] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [ ] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

clemsos avatar Oct 09 '24 14:10 clemsos

hitting size limit here

|·---------------------------|--------------------------------|--------------------------------·|
 |  Solc version: 0.7.6      ·  Optimizer enabled: true       ·  Runs: 80                      │
 |····························|································|·································|
 |  Contract Name            ·  Deployed size (KiB) (change)  ·  Initcode size (KiB) (change)  │
 ····························|································|·································
 |  MixinConvenienceOwnable  ·                      5.842 ()  ·                      5.870 ()  │
 ····························|································|·································
 |  MixinDisable             ·                      0.061 ()  ·                      0.086 ()  │
 ····························|································|·································
 |  MixinERC721Enumerable    ·                      8.882 ()  ·                      8.910 ()  │
 ····························|································|·································
 |  MixinErrors              ·                      0.061 ()  ·                      0.086 ()  │
 ····························|································|·································
 |  MixinFunds               ·                      0.138 ()  ·                      0.164 ()  │
 ····························|································|·································
 |  MixinGrantKeys           ·                     10.578 ()  ·                     10.606 ()  │
 ····························|································|·································
 |  MixinKeys                ·                      8.759 ()  ·                      8.787 ()  │
 ····························|································|·································
 |  MixinLockCore            ·                      5.598 ()  ·                      5.626 ()  │
 ····························|································|·································
 |  MixinLockMetadata        ·                     11.630 ()  ·                     11.658 ()  │
 ····························|································|·································
 |  MixinPurchase            ·                     15.330 ()  ·                     15.358 ()  │
 ····························|································|·································
 |  MixinRefunds             ·                     16.229 ()  ·                     16.257 ()  │
 ····························|································|·································
 |  MixinRoles               ·                      2.390 ()  ·                      2.418 ()  │
 ····························|································|·································
 |  MixinTransfer            ·                     17.983 ()  ·                     18.012 ()  │
 ····························|································|·································
 |  PublicLock               ·                     24.236 ()  ·                     24.266 ()  │
 ·---------------------------|--------------------------------|--------------------------------·

clemsos avatar Oct 16 '24 10:10 clemsos