unlock icon indicating copy to clipboard operation
unlock copied to clipboard

Upgrade to ESlint 9

Open julien51 opened this issue 1 year ago • 4 comments

The new ESLint version seems to break because the configuration is completely different. We are looking for someone to help migrate and we will pay a 300 USDC bounty for that work!

An extra step will be to make sure https://github.com/unlock-protocol/unlock/pull/14216 can also be merged!

julien51 avatar Aug 23 '24 19:08 julien51

I'll like to work on this. Should get it done by Monday

Myestery avatar Aug 23 '24 19:08 Myestery

Awesome @Myestery ! Assigned to you! Please get back to me on Monday with an update!

julien51 avatar Aug 23 '24 19:08 julien51

Hi @julien51 Started working on it last night. Found out that successfully upgrading to eslint 9 makes some lint checks to fail due to new rules. Am I meant to fix them or just make the upgrade in this PR? By fixing them, I mean updating the other files involved

Myestery avatar Aug 24 '24 14:08 Myestery

I was able to do the upgrade @julien51 however I have some unrelated tests failing

Myestery avatar Aug 26 '24 15:08 Myestery

hey @Myestery do you mind pasting a wallet address here on which I can send the payment opn Optimism or Base? Thanks!

julien51 avatar Sep 05 '24 14:09 julien51

USDC Base 0x70b6361545b12c81eb8c66d3fc4a4f5a03f64337

Thanks

Myestery avatar Sep 05 '24 14:09 Myestery

Thanks @Myestery ! This was just paid https://basescan.org/tx/0x896cddadb2ae7ad517574c5184441579f2dabaf42f681d4b7cf0cee0773c6e82

julien51 avatar Sep 11 '24 18:09 julien51

Thanks @Myestery ! This was just paid https://basescan.org/tx/0x896cddadb2ae7ad517574c5184441579f2dabaf42f681d4b7cf0cee0773c6e82

Confirmed with thanks

Myestery avatar Sep 11 '24 18:09 Myestery