unlock icon indicating copy to clipboard operation
unlock copied to clipboard

feat(networks): automated check when adding a new network

Open clemsos opened this issue 1 year ago • 3 comments

Description

Adds an automated check on the PR when adding a new network.

Issues

Fixes # Refs #13533

Checklist:

  • [ ] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [ ] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

clemsos avatar Jul 08 '24 15:07 clemsos


github-actions[bot] avatar Jul 11 '24 20:07 github-actions[bot]

ok let's do it!

i will remove the test file and merge then

clemsos avatar Sep 04 '24 17:09 clemsos

packages/networks/src/networks/avalanche.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Contract PublicLockLatest at 0x440d9D4E66d39bb28FB58729Cb4D3ead2A595591 is verified
  • ✅ Contract PublicLockPrevious at 0xF241F12506fb6Bf1909c6bC176A199166414007a is verified
  • ✅ Contract Unlock at 0x70cBE5F72dD85aA634d07d2227a421144Af734b3 is verified
  • ✅ Contract KeyManager at 0x8e0B46ec3B95c81355175693dA0083b00fCc1326 is verified
  • ✅ Contract onKeyPurchaseHook_CAPTCHA at 0x2499D94880B30fA505543550ac8a1e24cfFeFe78 is verified
  • ✅ Contract onKeyPurchaseHook_PASSWORD at 0x58D86Dc056c442867485941FeBeA8D3bB4657eAC is verified
  • ✅ Contract onKeyPurchaseHook_PROMO_CODE_CAPPED at 0x520294E736167303efa038205D4391b58261BC9c is verified
  • ✅ Contract onKeyPurchaseHook_PASSWORD_CAPPED at 0xa396CFB1fFe3ADD2308dF140aa2d0A520D5c6c31 is verified
  • ✅ Unlock source code at 0x70cBE5F72dD85aA634d07d2227a421144Af734b3 matches packaged UnlockV13
  • ✅ PublicLock source code at 0x440d9D4E66d39bb28FB58729Cb4D3ead2A595591 matches packaged PublicLockV14
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

packages/networks/src/networks/gnosis.ts

The setup is successful :

  • ✅ all mandatory keys are present
  • ✅ Contract PublicLockLatest at 0xeAd6d1877452383ab5F74c689b6C3d0538Fd3008 is verified
  • ✅ Contract PublicLockPrevious at 0x70cBE5F72dD85aA634d07d2227a421144Af734b3 is verified
  • ✅ Contract Unlock at 0x1bc53f4303c711cc693F6Ec3477B83703DcB317f is verified
  • ✅ Contract KeyManager at 0xBa81C9379AC1221BF8C100800dD0B0b0b048ba14 is verified
  • ✅ Contract UDTv3 at 0x8C84142c4a716a16a89d0e61707164d6107A9811 is verified
  • ✅ Contract onKeyPurchaseHook_GUILD at 0xe20738d9798B5B5801aEEFDB81d80Fcce3a3Aa95 is verified
  • ✅ Contract onKeyPurchaseHook_PROMO_CODE_CAPPED at 0x5ff4d5733Cc2b0A069cFF409eCEad3C5C71Ee346 is verified
  • ✅ Contract onKeyPurchaseHook_PASSWORD_CAPPED at 0x111C61BD66a8c4f142e452b9087Dae5893C5C3cF is verified
  • ✅ Contract onKeyPurchaseHook_GITCOIN at 0xd6129cAC45a16187F4D09Dd69C512F68F0f2B371 is verified
  • ✅ Unlock source code at 0x1bc53f4303c711cc693F6Ec3477B83703DcB317f matches packaged UnlockV13
  • ✅ Subgraph up and running
  • ✅ Unlock ownership correctly set to the multisig

We have found the following errors :

  • ❌ Contract onKeyPurchaseHook_PASSWORD at 0x927D68eAE936Ec0111f01Fc4Ddd9cC57DB3f0Af2 is not verified
  • ❌ Contract onKeyPurchaseHook_CAPTCHA at 0xFb0657eAE55A4dd3E2317C9eCB311bA5Ecc62C9C is not verified

Some verification calls have failed :

  • ❌ Could not fetch PublicLock source code from block explorer, TypeError: Cannot read properties of undefined (reading 'substring')

github-actions[bot] avatar Sep 05 '24 11:09 github-actions[bot]