unlock icon indicating copy to clipboard operation
unlock copied to clipboard

Published 20 hours ago • verified publisher icon unlock-protocol

Set protocol fee cross bridge proposal

Open blahkheart opened this issue 9 months ago • 1 comments

Description

Set protocol fee for the Unlock contract on mainnet and across all supported networks

Issues

Fixes #13826 Refs #13826

Checklist:

  • [x] 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have updated the docs to reflect my changes if applicable
  • [ ] I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • [x] I have performed a self-review of my own code
  • [ ] If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

blahkheart avatar May 13 '24 03:05 blahkheart

@julien51 @clemsos could you please review this pull request?

blahkheart avatar May 13 '24 03:05 blahkheart

Thanks a lot @blahkheart ! Please make sure you clean things up... and have you tried running the simulation/test? @clemsos can probably provide more details on how to achieve this!

Okay, noted.

blahkheart avatar May 14 '24 11:05 blahkheart

Thanks a lot @blahkheart ! Please make sure you clean things up... and have you tried running the simulation/test? @clemsos can probably provide more details on how to achieve this!

Okay, noted.

Yes, @blahkheart you can run a simulation by using

cd governance
RUN_FORK=1 yarn hardhat gov --proposal proposals/012-set-protocol-fee-cross-bridge.js --gov-address 0x440d9D4E66d39bb28FB58729Cb4D3ead2A595591

clemsos avatar May 14 '24 12:05 clemsos

@clemsos, @julien51 Please review the latest changes. Simulation/test passed

blahkheart avatar May 22 '24 16:05 blahkheart

@clemsos, @julien51 Please review the latest changes. Simulation/test passed

That is great ! I just tested the proposal on receiving chains using Tenderly simulations. The only thing that needs to be changed is the operation field that should be set to zero instead of one (my mistake here).

Other than that it all works :)

  • Gnosis Chain [100]: https://dashboard.tenderly.co/clemsos/project/fork/f9ffc90d-d153-46bb-8b14-8afa0c0cb904
  • Polygon [137]: https://dashboard.tenderly.co/clemsos/project/fork/12e044db-bbc1-4825-ade9-8c4a6e68d5e2
  • Arbitrum [42161]: https://dashboard.tenderly.co/clemsos/project/fork/5ed95b15-20e3-4087-986b-84af0f217a63
  • Optimism [10]: https://dashboard.tenderly.co/clemsos/project/fork/e5675613-7795-48a7-ba61-3682e1e94554
  • Base [8453]: https://dashboard.tenderly.co/clemsos/project/fork/bcaa122a-cc25-4010-9cb0-79c1389dd939
  • BNB Chain [56]: https://dashboard.tenderly.co/clemsos/project/fork/344c9563-73cd-4d1e-ac28-408694aa409f

(tests here have been run with the operation field changed to 0)

clemsos avatar May 23 '24 12:05 clemsos