unlock icon indicating copy to clipboard operation
unlock copied to clipboard

Deprecate support for old version of Unlock

Open julien51 opened this issue 1 year ago • 3 comments

Supporting multiple version of Unlock + PublicLock is creating extra complexity. We should start thinking about deprecating support.

For this, the first step would be to look at any lock on any network that has received at least 1 transaction in 2023 and check their version. We should keep supporting any version for which that is the case.

Once we identify which version we need to keep supporting, we can remove support for older versions. I suggest removing the support from unlock-js, but also from the smart-contract as well as the contracts package.

Actions:

  • [ ] create script that list all locks created on a network
  • [ ] finds latest transaction sent to lock
  • [ ] check the balance on the lock
  • [ ] keep track of any lock with a balance > 1$, as well as the one which received any transaction in 2023
  • [ ] remove "stale" versions from smart-contarcts
  • [ ] remove "stale" versions from unlock-js
  • [ ] remove "stale" version from packages/contracts

julien51 avatar Mar 12 '24 00:03 julien51

The best way to achieve this could probably be to update the subgraph so that we keep track of the latest time a lock has been "interacted" with (purchase, withdraw...).

julien51 avatar Mar 21 '24 14:03 julien51

we need to check also if the old locks has balance

clemsos avatar Jun 20 '24 16:06 clemsos

depends on #14080

clemsos avatar Jul 04 '24 11:07 clemsos