unlock icon indicating copy to clipboard operation
unlock copied to clipboard
verified publisher icon unlock-protocol

Do not publish `localhost` network in npm package

Open julien51 opened this issue 1 year ago • 2 comments

Our networks package on npm includes the localhost network. We should probably not include it :)

julien51 avatar Feb 02 '24 22:02 julien51

Yes that's legacy before we had a dedicated parser for networks. I'll remove it

clemsos avatar Feb 05 '24 11:02 clemsos

Actually this seems to break tests :/ https://github.com/unlock-protocol/unlock/actions/runs/7788613303/job/21238405638

Can we just remove it from the package we ship to npm but keep it locally?

julien51 avatar Feb 05 '24 19:02 julien51