unlock icon indicating copy to clipboard operation
unlock copied to clipboard
verified publisher icon unlock-protocol

We are testing against Goerli... and this is not right

Open julien51 opened this issue 2 years ago • 6 comments

Some unlockjs tests are apparently running againt Goerli. This is dangerous because it breaks our tests when something is wrong on goerli.

We should never test against any external data source (chain, subgraphs... etc)

julien51 avatar Apr 04 '23 01:04 julien51

Example of failed jobs because of this https://github.com/unlock-protocol/unlock/actions/runs/4602690240/jobs/8131935944

julien51 avatar Apr 04 '23 01:04 julien51

It seems to be here https://github.com/unlock-protocol/unlock/blob/de0df50c28bb0864f31859aa59c2a30a20374986/packages/unlock-js/src/tests/web3Service.test.js#L8

clemsos avatar May 10 '23 10:05 clemsos

That may start to fail when goerli gets deprec

clemsos avatar Sep 25 '23 12:09 clemsos

Subgraph get its introspection file from Goerli too

clemsos avatar Oct 26 '23 13:10 clemsos

we are now testing against Optimism https://github.com/unlock-protocol/unlock/pull/13540

clemsos avatar Mar 30 '24 07:03 clemsos

Subgraph get its introspection file from Goerli too

This was changed to mainnet a while ago

clemsos avatar Mar 30 '24 07:03 clemsos