greenlight
greenlight copied to clipboard
unknownskl
Fix AMD video HW Accel and lib path, #1079
Can you please elaborate what this PR should fix? I see in the code that you are checking the gpu internals and im kind of wondering which option you are trying to activate? Maybe there is another way to achieve the same goal which is more electron friendly.
The actual change is flatpak/io.github.unknownskl.greenlight.yml and electron to 25. First fix wrong path, second because 27 removed hardware decoder VDADecoder for H264. GPU info is in comment for possible future debugging.
I still dont fully understand what problem you are experiencing and what this should fix. As for the downgrade to electron 25 i would prefer not to pin the version of the Framework. Electron 25 is EOL in about 5/6 days from now and that would expose additional security risks and compatibility issues in the future.
Since this is a single purpose userspace app I don't think there're additional attack surface if future exploits are found in electron. Without this hw decoder patch it's unusable on Steam Deck without hammering the CPU thus battery.
Keeping dependencies up to date is quite important in the long run. On my steam deck the app only uses between 6-8 watts while streaming and results in a suggested battery life of +- 5 hours (not real benchmarks though). The cpu usage sits between 20-40%. Do you encounter different numbers on your Steam deck?
Do you have numbers on how much this would improve cpu wise and in terms of energy usage?
Around 7W. 1080P AVC decoder is not that hard on modern CPU. But bigger problem is SW decoder much higher latency on top of already awful Microsoft's streaming implementation on Xbox Series.. No idea how they messed up low latency encoder on its Zen 2 + RDNA 2 combo and no HEVC, no 4K. no HDR, only 1080P + AVC. On PC this GPU combo Sunshine + Moonlight can get full chain latency under 20ms(Click + Encode + over Network + Decode)...