fix: settings card regression on billing page
What does this PR do?
Fixes # (issue)
Eng-1786
If there is not an issue for this, please create one first. This is used to tracking purposes and also helps use understand why this PR exists
Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Chore (refactoring code, technical debt, workflow improvements)
- [ ] Enhancement (small improvements)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update
How should this be tested?
Content is vertically centered in card. Button has more padding Does not break any settings page styles
Checklist
Required
- [x] Filled out the "How to test" section in this PR
- [x] Read Contributing Guide
- [x] Self-reviewed my own code
- [x] Commented on my code in hard-to-understand areas
- [x] Ran
pnpm build - [x] Ran
pnpm fmt - [x] Checked for warnings, there are none
- [x] Removed all
console.logs - [x] Merged the latest changes from main onto my branch with
git pull origin main - [x] My changes don't cause any responsiveness issues
Appreciated
- [ ] If a UI change was made: Added a screen recording or screenshots to this PR
- [ ] Updated the Unkey Docs if changes were necessary
Summary by CodeRabbit
-
Style
- Increased the width of various settings panels and input fields across the dashboard for improved readability and layout consistency.
- Adjusted vertical and horizontal alignment, spacing, and padding of form elements and buttons for a more polished and cohesive user interface.
- Updated button and form input visuals, including enhanced loading indicators and accessibility improvements.
-
Refactor
- Refined layout structures for settings and form components to ensure consistent appearance across different sections.
⚠️ No Changeset found
Latest commit: d0bbb624f8f7e30f3c81686b489c5b94ac4e094d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| dashboard | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 12, 2025 2:16pm |
1 Skipped Deployment
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| engineering | ⬜️ Ignored (Inspect) | Visit Preview | May 12, 2025 2:16pm |
📝 Walkthrough
Walkthrough
This update standardizes and increases the width of various settings-related UI components across the dashboard application, primarily by adjusting Tailwind CSS classes. The changes affect layout, spacing, and alignment in forms and cards, without altering any underlying logic, state management, or event handling.
Changes
| File(s) | Change Summary |
|---|---|
| .../settings/components/copy-api-id.tsx .../settings/components/default-bytes.tsx .../settings/components/default-prefix.tsx .../settings/components/delete-api.tsx .../settings/components/delete-protection.tsx .../settings/components/update-api-name.tsx .../settings/components/update-ip-whitelist.tsx |
Increased content/card widths from 320px to 420px on large screens, removed or adjusted margin/padding classes, and slightly increased input widths for better alignment and spacing. No logic changes. |
| .../settings/components/settings-client.tsx .../authorization/permissions/[permissionId]/settings-client.tsx .../authorization/roles/[roleId]/settings-client.tsx .../ratelimits/[namespaceId]/settings/components/settings-client.tsx .../settings/general/page.tsx .../settings/billing/components/shell.tsx |
Increased main container widths from 760px to 900px for more spacious layouts. No logic or control flow changes. |
| .../settings/general/copy-workspace-id.tsx .../settings/general/update-workspace-name.tsx |
Increased SettingCard/content widths to 420px, adjusted input widths and alignment, and removed some margin classes. No functional changes. |
| internal/ui/src/components/settings-card.tsx | Changed default content width from 320px to 420px, increased vertical padding, updated alignment and width classes for title/description and children containers. No changes to exported signatures. |
Sequence Diagram(s)
sequenceDiagram
participant User
participant SettingsPage
participant SettingCard
User->>SettingsPage: Navigates to settings
SettingsPage->>SettingCard: Renders card with updated width/layout
SettingCard-->>User: Displays wider, aligned UI components
Suggested labels
🕹️ oss.gg
Suggested reviewers
- chronark
[!TIP]
⚡️ Faster reviews with caching
- CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure
Review - Disable Cacheat either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off theData Retentionsetting under your Organization Settings.Enjoy the performance boost—your workflow just got faster.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between c445381e7de2d36644733423694da11d44e99b5a and d0bbb624f8f7e30f3c81686b489c5b94ac4e094d.
📒 Files selected for processing (3)
apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-api.tsx(2 hunks)apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-protection.tsx(1 hunks)apps/dashboard/app/(app)/apis/[apiId]/settings/components/update-ip-whitelist.tsx(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-protection.tsx
- apps/dashboard/app/(app)/apis/[apiId]/settings/components/update-ip-whitelist.tsx
- apps/dashboard/app/(app)/apis/[apiId]/settings/components/delete-api.tsx
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Test Go API Local / Test (Shard 4/8)
- GitHub Check: Test Go API Local / Test (Shard 5/8)
- GitHub Check: Build / Build
- GitHub Check: Test Go API Local / Test (Shard 3/8)
- GitHub Check: Test Go API Local / Test (Shard 1/8)
- GitHub Check: Test Go API Local / Test (Shard 2/8)
- GitHub Check: Test API / API Test Local
✨ Finishing Touches
- [ ] 📝 Generate Docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai generate docstringsto generate docstrings for this PR.@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Thank you for following the naming conventions for pull request titles! 🙏
I don't feel super happy about hardcoding the pixel width, to me that just kicks the problem down to the next person :D
what am I missing?
I think in this context its acceptable. We can think of it as limiting your websites width like this. That settings card might not look as good as its now, but I see what you mean 🙏. Maybe its time to consult Vitor image.png