unkey icon indicating copy to clipboard operation
unkey copied to clipboard

Bug: Last used login Indicator should display only after successful login or return to login screen

Open JeevaRamanathan opened this issue 1 year ago • 11 comments

Preliminary Checks

  • [X] I have reviewed the documentation: https://unkey.com/docs

  • [X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues

  • [X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

The last used indicator is displayed at the moment the the auth type (Google/Github) button is clicked

Steps to Reproduce

In SignIn screen (https://app.unkey.com/auth/sign-in)) click on either Google or GitHub login.

Expected behavior

Last used indicator should be displayed on only when coming back to login screen after successful login. https://app.formbricks.com/auth/login

Other information

No response

Screenshots

https://github.com/user-attachments/assets/1d324326-6db1-4131-bf5c-e987cf8ed1a3

Version info

- OS:Windows

JeevaRamanathan avatar Oct 14 '24 06:10 JeevaRamanathan

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Oct 14 '24 06:10 oss-gg[bot]

/assign

naaa760 avatar Oct 14 '24 07:10 naaa760

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Oct 14 '24 07:10 oss-gg[bot]

@JeevaRamanathan would you like to assign this issue?

naaa760 avatar Oct 14 '24 07:10 naaa760

Suppose the login fails or it is aborted. It would show the last attempted login. I don't know if this is a bug. But let us wait for someone from the Unkey team to review this.

harshsbhat avatar Oct 14 '24 08:10 harshsbhat

@harshsbhat yes but what am addressing is different. If you could keenly on the formbricks and this unkey; the moment when the login is clicked before navigating to next screen the last used indicator is shown.


@naaa760 it's currently in "Needs approval" and i 'ant the moderator to assign; thanks!

JeevaRamanathan avatar Oct 14 '24 13:10 JeevaRamanathan

I don't really see a problem with this it shows the intent of what auth you want to use.

If you abort and use something else, it will update correctly

chronark avatar Oct 15 '24 08:10 chronark

@chronark But the last used indicator should only display when returning to the login screen after a successful or unsuccessful login, not immediately upon selecting an authentication method. Indicating the moment as "last used" might not be accurate as the current authentication process is ongoing.

Additionally, I don't see any option to abort unless the user clicks on another method while one is loading (if I understand this correctly). For example: https://lex.page/auth, https://app.formbricks.com/auth/login (Even on a failed attempt it is indicated once the user is back to login screen)

JeevaRamanathan avatar Oct 15 '24 14:10 JeevaRamanathan

/assign

sanyamhbtu avatar Oct 18 '24 15:10 sanyamhbtu

This issue is not part of oss.gg hackathon. Please pick a different one or start with a side quest

oss-gg[bot] avatar Oct 18 '24 15:10 oss-gg[bot]