unkey Deleting the override doesn't remove it from the overrides. Refreshing it will give you a client side error.

Preliminary Checks

[X] I have reviewed the documentation: https://unkey.com/docs
[X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues
[X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

After deleting the override it is still displayed in the overrides. If you click on it the whole UI breaks

Steps to Reproduce

Go to a /ratelimit and create a new ratelimit
Create a new override and delete it.
It is still displayed under all overrides.
If you refresh it the whole UI will break

Expected behavior

Once deleted it should not be visbile in the ratelimit/id/overrides .

Other information

No response

Screenshots

https://www.loom.com/share/030e5263e3ea44c5bdc1d03c882b790a?sid=53973849-b8a4-49a0-9c5d-18fc91b79fe4

Version info

- OS:
- Node:
- npm:

Oct 07 '24 14:10 harshsbhat

ENG-1397 Deleting the override doesn't remove it from the overrides. Refreshing it will give you a client side error.

Oct 07 '24 14:10 linear[bot]

We're probably not checking the deletedAt column when doing the query to list all ratelimits

that should fix this I believe

Oct 07 '24 14:10 chronark

/award 150

Oct 07 '24 14:10 chronark

Awarding harshsbhat: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/harshsbhat

Oct 07 '24 14:10 oss-gg[bot]

/assign

Oct 07 '24 16:10 HarshitVashisht11

Assigned to @HarshitVashisht11! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Oct 07 '24 16:10 oss-gg[bot]

@HarshitVashisht11, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

Oct 09 '24 04:10 oss-gg[bot]

/assign

Oct 10 '24 12:10 AakashRao-dev

This issue is already assigned to another person. Please find more issues here.

Oct 10 '24 12:10 oss-gg[bot]

/unassign

Oct 10 '24 13:10 HarshitVashisht11

Issue unassigned.

Oct 10 '24 13:10 oss-gg[bot]

/assign

Oct 10 '24 13:10 alokdangre

Assigned to @Studycode001! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

Oct 10 '24 13:10 oss-gg[bot]

/assign