unkey icon indicating copy to clipboard operation
unkey copied to clipboard

[🕹️] Audit Logs filtering by system shows no bucket message

Open Flo4604 opened this issue 1 year ago • 9 comments

Preliminary Checks

  • [X] I have reviewed the documentation: https://unkey.com/docs

  • [X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues

  • [X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

When I select a rate limit namespace, I get a message with no bucket found. This can happen when a new rate limit has never been used or the bucket for its logs didn't get created yet.

Also, the root keys filter shows the root keys that have already been deleted, as well as rate limits that do not exist anymore

Steps to Reproduce

  1. Go to audit logs
  2. Select system message
  3. In case of no logs it shows bucket has not been found

Expected behavior

I would love to have a 404 page that shows me that no logs have been found, but I can still see the filters, so I can change them without having to back out of the whole page or press the audit log tab again.

I would also like the page to show which root keys/rate limits are still active, as those events are often more critical when filtering, or at least knowing which ones could help.

Other information

No response

Screenshots

https://github.com/user-attachments/assets/e959c8bf-652e-4e26-ac42-587ad9ef3a0b

Version info

-

Flo4604 avatar Oct 05 '24 20:10 Flo4604

related to what I sent you in discord yesterday, it should be fixed now, but I'll double check

chronark avatar Oct 06 '24 09:10 chronark

update: the deployment failed, will investigate and get this rolled out today

chronark avatar Oct 06 '24 09:10 chronark

@chronark fyi, I can reproduce this behaviour too. Not sure it's a bug though, but it's definitely an UX issue. From what I can see in the code, the condition that renders the "Bucket Not Found" placeholder is simply above the entire "Audit Logs" page.

unrenamed avatar Oct 12 '24 22:10 unrenamed

@unrenamed let's fix it :)

chronark avatar Oct 13 '24 10:10 chronark

/award 150

chronark avatar Oct 13 '24 10:10 chronark

Awarding Flo4604: 150 points 🕹️ Well done! Check out your new contribution on oss.gg/Flo4604

oss-gg[bot] avatar Oct 13 '24 10:10 oss-gg[bot]

/assign

unrenamed avatar Oct 13 '24 10:10 unrenamed

Assigned to @unrenamed! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 13 '24 10:10 oss-gg[bot]