unkey icon indicating copy to clipboard operation
unkey copied to clipboard

[đŸ•šī¸] API Key sub-optimal display permissions of permissions

Open Flo4604 opened this issue 1 year ago â€ĸ 16 comments

Preliminary Checks

  • [X] I have reviewed the documentation: https://unkey.com/docs

  • [X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues

  • [X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

Currently, the way assigned / not assigned permissions of a key are displayed is not the most optimal way I think.

For me, this is the result of a few points:

  1. It's displayed as a graph => I don't really understand why but a checkbox tree would be more accessible and is also used in the Authorization -> Roles -> SomeRole -> Permissions tab which would be more consistent.
  2. With a lot of permissions the graph just becomes unreadable as its too stacked vertically
  3. What is the point of having the ability to drag permissions onto a key if it does nothing
  4. The permission names are cut off and there is no tooltip when hovering over them showing the full name

I think the way assigned / not assigned permissions of a key are displayed is not the most optimal way

Steps to Reproduce

  1. Create loads of permissions and assign some of them to roles
  2. Assign a single role to the key
  3. See how it looks Please see attached video

Expected behavior

I would expect this to be shown more straightforwardly, maybe just by taking the checkbox tree instead of this graph

Other information

https://github.com/user-attachments/assets/6c6de094-c0c5-4b12-9877-bc42a5caf302

Screenshots

No response

Version info

-

Flo4604 avatar Oct 04 '24 22:10 Flo4604

Flo on the streak of creating new issues đŸ’ĒđŸ”Ĩ

harshsbhat avatar Oct 05 '24 03:10 harshsbhat

I don't really understand why

I got carried away lol

I agree though, while it looked neat, I can totally see how this is annoying to use. We should change it.

chronark avatar Oct 05 '24 10:10 chronark

/award 150 points

chronark avatar Oct 05 '24 10:10 chronark

Awarding Flo4604: 150 points đŸ•šī¸ Well done! Check out your new contribution on oss.gg/Flo4604

oss-gg[bot] avatar Oct 05 '24 10:10 oss-gg[bot]

/assign

RajuGangitla avatar Oct 05 '24 10:10 RajuGangitla

Assigned to @RajuGangitla! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 05 '24 10:10 oss-gg[bot]

@chronark can i replace this current component

image

to the one we are using as a tree structure

image

RajuGangitla avatar Oct 05 '24 19:10 RajuGangitla

/assign

Mackhack0705 avatar Oct 10 '24 12:10 Mackhack0705

Assigned to @Mackhack0705! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 10 '24 12:10 oss-gg[bot]

Hey @Mackhack0705 I already worked on this issue and pr is under review

RajuGangitla avatar Oct 10 '24 12:10 RajuGangitla

Okay @RajuGangitla , I also want to contribute to it. I only see that this issue is available. If your PR gets merged, that's okay; otherwise, I am also working.

Mackhack0705 avatar Oct 10 '24 12:10 Mackhack0705

/award 150 points

vivek-gorantla2005 avatar Oct 11 '24 00:10 vivek-gorantla2005

You are not allowed to award points! Please contact an admin.

oss-gg[bot] avatar Oct 11 '24 00:10 oss-gg[bot]

/assign

Sashank-Singh avatar Oct 11 '24 05:10 Sashank-Singh

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 05:10 oss-gg[bot]