unkey icon indicating copy to clipboard operation
unkey copied to clipboard

[đŸ•šī¸] Some toasts keep showing as loading even when they finish

Open Flo4604 opened this issue 1 year ago â€ĸ 21 comments

Preliminary Checks

  • [X] I have reviewed the documentation: https://unkey.com/docs

  • [X] I have searched for existing issues: https://github.com/unkeyed/unkey/issues

  • [X] This issue is not a question, general help request, or anything other than a bug report directly related to Unkey. Please ask questions in our Discord community: https://unkey.com/discord.

Reproduction / Replay Link (Optional)

No response

Issue Summary

Sometimes when you trigger a action that shows a toast in the bottom left the initial loading toast will stay shown even if the action succeeded / failed

Steps to Reproduce

Try this with adding a role to a API key ( see replication video )

Expected behavior

All toast should hide after they are done

Other information

No response

Screenshots

https://github.com/user-attachments/assets/38f0c445-1125-49a1-a94c-164ba33a7a0f

Version info

-

Flo4604 avatar Oct 04 '24 22:10 Flo4604

This is mostly the case with the Permission related buttons

harshsbhat avatar Oct 05 '24 03:10 harshsbhat

/assign

prave01 avatar Oct 05 '24 09:10 prave01

/assign

you will need to wait until the need approval is removed

harshsbhat avatar Oct 05 '24 09:10 harshsbhat

/award 150 points

chronark avatar Oct 05 '24 11:10 chronark

Awarding Flo4604: 150 points đŸ•šī¸ Well done! Check out your new contribution on oss.gg/Flo4604

oss-gg[bot] avatar Oct 05 '24 11:10 oss-gg[bot]

@PraveenThanikachalam try again

chronark avatar Oct 05 '24 11:10 chronark

/assign

prave01 avatar Oct 05 '24 11:10 prave01

Assigned to @PraveenThanikachalam! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 05 '24 11:10 oss-gg[bot]

@PraveenThanikachalam, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 06 '24 23:10 oss-gg[bot]

@PraveenThanikachalam, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

oss-gg[bot] avatar Oct 08 '24 23:10 oss-gg[bot]

/assign

IAmRiteshKoushik avatar Oct 10 '24 14:10 IAmRiteshKoushik

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 10 '24 14:10 oss-gg[bot]

/assign

AkshayBandi027 avatar Oct 10 '24 16:10 AkshayBandi027

You already have an open issue assigned to you here. Once that's closed or unassigned, only then we recommend you to take up more.

oss-gg[bot] avatar Oct 10 '24 16:10 oss-gg[bot]

I think pr is in review and almost in completed ! I am working this issue !!

AkshayBandi027 avatar Oct 10 '24 16:10 AkshayBandi027

/assign

imnirajky avatar Oct 10 '24 16:10 imnirajky

Assigned to @imnirajky! Please open a draft PR linking this issue within 48h âš ī¸ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically đŸ•šī¸ Excited to have you ship this 🚀

oss-gg[bot] avatar Oct 10 '24 16:10 oss-gg[bot]

hey @imnirajky! I have worked on the issue and created a pull request could just backoff this issue please ? I tried to assign myself about another pr was in review but so oss-gg declined it!

AkshayBandi027 avatar Oct 10 '24 16:10 AkshayBandi027

/assign

Anky9972 avatar Oct 11 '24 05:10 Anky9972

This issue is already assigned to another person. Please find more issues here.

oss-gg[bot] avatar Oct 11 '24 05:10 oss-gg[bot]