website icon indicating copy to clipboard operation
website copied to clipboard

feat: add Bluesky account link on footer

Open shuuji3 opened this issue 1 year ago โ€ข 4 comments

๐Ÿ”— Linked issue

resolve #345

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] ๐Ÿ“ฐ Content (a new article or a change in the content folder)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

As written in the original issue, not having a Bluesky link makes it a bit difficult for new users to find a Bluesky account.

This PR adds two changes:

  • add Bluesky account icon link on the footer
  • adjust LD+JSON for the website to include Bluesky account profile

This helps new users find an account in an open platform where anyone who has Internet access can see the latest posts, unlike the other closed social media.

Screenshot of footer, which has new Bluesky icon (with new Bluesky link icon)

Screenshot of footer, which has new Bluesky icon (when hovering the mouse cursor)

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.
    • N/A for docs

shuuji3 avatar Dec 28 '24 06:12 shuuji3

I also noticed there are other twitter links in Blog post etc. If you'd like to update those, I can help update them as well (by this PR or the other PR).

shuuji3 avatar Dec 28 '24 06:12 shuuji3

Aside from that, it'd be nice to add a Bluesky account link to unjs org profile too: https://github.com/unjs

screenshot of the above org profile page

shuuji3 avatar Dec 28 '24 08:12 shuuji3

Thanks for nice work and suggstion. I have updated org, this repository needs little bit maintenance first.

pi0 avatar Dec 28 '24 09:12 pi0

I made a separate PR to fix the lint errors on main branch: #347. This would solve the current CI failure. It needed only a few lines of change.

shuuji3 avatar Dec 28 '24 13:12 shuuji3