unstorage icon indicating copy to clipboard operation
unstorage copied to clipboard

feat(azure-drivers): add managed identity client ID support

Open itpropro opened this issue 11 months ago • 4 comments

Enhance Azure drivers to support user-assigned managed identity authentication by adding an optional managedIdentityClientId parameter. This allows choosing the correct user assigned managed identity to use.

Changes:

  • Added managedIdentityClientId option to driver interfaces to use with DefaultAzureCredential if provided
  • Improved authentication flexibility for Azure services
  • Fixing a bug with CosmosDB syntax that changed that didn't came up due to disabled test suites
  • Fixed removeItem throws in CosmosDB driver
  • Improved stability of Key Vault and it's test suite by introducing a wait of 750ms (average time to purge) only after clean if purge is provided
  • Added a parameter to disablePurging for Key Vaults with enabled purge protection

All changes are tested against the local emulator (if available) and live Azure resources.

itpropro avatar Jan 29 '25 01:01 itpropro

Deploying unstorage with  Cloudflare Pages  Cloudflare Pages

Latest commit: 50a60ab
Status: ✅  Deploy successful!
Preview URL: https://2897dcb3.unstorage.pages.dev
Branch Preview URL: https://feat-azure-authentication.unstorage.pages.dev

View logs

Appreciate the PR but please consider splitting changes next times, it is clearly written in PR template.

  1. Please keep your changes minimal and split them if you need to.

pi0 avatar Jan 29 '25 13:01 pi0

Appreciate the PR but please consider splitting changes next times, it is clearly written in PR template.

  1. Please keep your changes minimal and split them if you need to.

I can of course split this, the errors just occured "on accident" when running the test suites and for the changes to be validated properly, I needed the test suites to be representative. It's no problem to split out the the fixes separately if you want, just wanted to save you the review work :)

itpropro avatar Jan 29 '25 14:01 itpropro

no worries on this one is good 👍🏼 (sorry might be back on this with some delay)

pi0 avatar Jan 29 '25 16:01 pi0