unstorage icon indicating copy to clipboard operation
unstorage copied to clipboard

feat(azure-storage-blob): native `maxDepth` support

Open 43081j opened this issue 1 year ago • 6 comments

Implements native maxDepth for the azure-storage-blob driver by using hierarchical fetches.

the tests are skipped for whatever reason, but I ran them locally and they pass

43081j avatar Dec 29 '24 11:12 43081j

Codecov Report

Attention: Patch coverage is 9.75610% with 37 lines in your changes missing coverage. Please review.

Project coverage is 58.78%. Comparing base (70310f9) to head (8b8334a). Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
src/drivers/azure-storage-blob.ts 9.75% 37 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
- Coverage   59.99%   58.78%   -1.22%     
==========================================
  Files          42       42              
  Lines        3657     3809     +152     
  Branches      590      600      +10     
==========================================
+ Hits         2194     2239      +45     
- Misses       1460     1567     +107     
  Partials        3        3              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 29 '24 12:12 codecov[bot]

@pi0 do you know why we disabled these tests?

when I run them locally, they seem to work fairly well if teardown happens cleanly

43081j avatar Jan 06 '25 15:01 43081j

IIRC tests were super flakey some point in CI.

(sorry for delay, trying to find some time to review. might delay this PR)

pi0 avatar Jan 07 '25 22:01 pi0

No rush at all. We can keep these tests disabled for now if you like

They do pass locally at least

43081j avatar Jan 07 '25 22:01 43081j

@pi0 what do you think about merging this one? 👀

43081j avatar Jan 21 '25 13:01 43081j

Still have to check better. Really no ETA sorry, i appreciate if you stay patient 🙏🏼

pi0 avatar Jan 21 '25 14:01 pi0

@43081j can you please check merge conflict?

pi0 avatar Apr 27 '25 16:04 pi0

should be caught up now 👍

43081j avatar Apr 27 '25 17:04 43081j