unplugin icon indicating copy to clipboard operation
unplugin copied to clipboard

feat: support `farm` plugin

Open ErKeLost opened this issue 2 years ago โ€ข 4 comments

๐Ÿ”— Linked issue

close #340

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

ErKeLost avatar Sep 24 '23 04:09 ErKeLost

Inquiries about my Pull Request merger


hi . I'm sorry to bother you whether this pr can be merged, I think we are ready, unplugin will be an important part of the ecological environment of farm, or do you have any concerns ?

If you need any additional information or assistance to review my PR, I will try my best to provide it. I appreciate your time and efforts, as well as your support for farm.

Thank you! @antfu

ErKeLost avatar Oct 03 '23 11:10 ErKeLost

Hey, sorry for the late rely. I heard that Farm has become Vite-compactible to some extent. Is this PR still relevant? I am ok with having farm supported if there is anything more specific than Vite plugin, but hope the complexity included here could be slim down a bit as we won't have a lot of knowledge to maintain it in the long term. Thanks

antfu avatar Dec 26 '23 14:12 antfu

Thank you very much for your reply. Farm is currently compatible with vite Ecology. Our successful adaptation such as unocss means that we have achieved success in compatible vite Ecology, but we cannot guarantee compatibility with all api of vite, so we prefer to use farm plug-in system to write plug-ins. We will release 1.0 soon. Before that, I will modify the current pr to reduce the complexity and maintainability of the code as much as possible, and I am happy to join the unplugin family. Thanks

ErKeLost avatar Dec 27 '23 05:12 ErKeLost

Great, looking forward to that! Converted this PR to draft, feel free to mark it as ready when you feel it's good to merge. Thanks

antfu avatar Jan 08 '24 11:01 antfu

Hi @antfu Farm has released 1.0.0-beta! At this exciting moment, I think we are ready. I feel like we are ready to move forward.

ErKeLost avatar Mar 12 '24 14:03 ErKeLost

The document has also been modified to complete the home page. I added the features of rolldown and farm I don't know if you agree to do this.

ErKeLost avatar Mar 13 '24 08:03 ErKeLost

Looks good to me, thank you! @ErKeLost Is that ok for us to ping you when we have issues regarding the farm integration, if any, later on?

antfu avatar Mar 13 '24 08:03 antfu

@antfu I am very happy to integrate unplugin, because unplugin directly transforms into a farm's js plugin, which is different from directly using vite's plugin logic, so unplugin will be an important part of the farm ecosystem. I am also very willing to grow together with unplugin. If there are any issues, I will solve them as soon as possible.

ErKeLost avatar Mar 13 '24 08:03 ErKeLost