scule
scule copied to clipboard
fix: Split by case should take space into account
fix #95 fix #92
I think for the titleCase, the , should not be took into account.
It seem all punctuation needs to be preserved, do we need to take all punctuation into account and filter them at titleCase?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 100.00%. Comparing base (
32ee7f5) to head (c0a6e9a). Report is 17 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 340 364 +24
Branches 39 45 +6
=========================================
+ Hits 340 364 +24
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🚨 Try these New Features:
- Flaky Tests Detection - Detect and resolve failed and flaky tests
- JS Bundle Analysis - Avoid shipping oversized bundles
It seem all punctuation needs to be preserved
I think that would make sense. Little bit tricky as makes change potential behavior breaking change.
I suggest to go one with this PR as-is and another followup later for v2
It seem all punctuation needs to be preserved
I think that would make sense. Little bit tricky as makes change potential behavior breaking change.
I suggest to go one with this PR as-is and another followup later for v2
Ok, this PR is ready
When will the follow-up work be planned? I 'd be happy to help.