scule icon indicating copy to clipboard operation
scule copied to clipboard

fix: Split by case should take space into account

Open noootwo opened this issue 1 year ago • 4 comments
trafficstars

fix #95 fix #92

I think for the titleCase, the , should not be took into account.

noootwo avatar Nov 21 '24 10:11 noootwo

It seem all punctuation needs to be preserved, do we need to take all punctuation into account and filter them at titleCase?

noootwo avatar Nov 21 '24 10:11 noootwo

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (32ee7f5) to head (c0a6e9a). Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #98   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          340       364   +24     
  Branches        39        45    +6     
=========================================
+ Hits           340       364   +24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features:

codecov[bot] avatar Nov 21 '24 16:11 codecov[bot]

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

pi0 avatar Nov 21 '24 16:11 pi0

It seem all punctuation needs to be preserved

I think that would make sense. Little bit tricky as makes change potential behavior breaking change.

I suggest to go one with this PR as-is and another followup later for v2

Ok, this PR is ready

When will the follow-up work be planned? I 'd be happy to help.

noootwo avatar Nov 22 '24 02:11 noootwo