pkg-types icon indicating copy to clipboard operation
pkg-types copied to clipboard

fix: optional fields from `publishConfig`

Open sxzz opened this issue 1 year ago • 1 comments

sxzz avatar Sep 05 '24 19:09 sxzz

@pi0 Could you review this, or should I merge the PR directly?

sxzz avatar Sep 08 '24 23:09 sxzz

Please do not merge PRs unless you are explicit maintainer of repository.

https://github.com/unjs/governance

pi0 avatar Oct 08 '24 07:10 pi0

It's been over two months since I submitted PR https://github.com/unjs/pkg-types/pull/193. I've also pinged you during this time, but there hasn't been any response.

If merging is an issue, I apologize and feel free to revert it.

sxzz avatar Oct 08 '24 08:10 sxzz

PR is fine. I didn't merge because had to investigate why our tests didn't catch it).

You could reach out again if it was a critical issue. we have several communication channels.

As an open-source maintainer, you would understand why PRs can get delayed to land. (

pi0 avatar Oct 08 '24 08:10 pi0