nitro icon indicating copy to clipboard operation
nitro copied to clipboard

fix: add code location and codeframe for rollup errors

Open danielroe opened this issue 2 years ago • 1 comments

🔗 Linked issue

resolves #165

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation or readme)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [x] 👌 Enhancement (improving an existing functionality like performance)
  • [ ] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR adds clickable code location and codeframe for rollup build errors.


CleanShot 2022-08-10 at 14 22 39


CleanShot 2022-08-10 at 21 38 46@2x

📝 Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

danielroe avatar Aug 10 '22 13:08 danielroe

Codecov Report

Merging #406 (158b52c) into main (d1d1015) will decrease coverage by 0.30%. The diff coverage is 65.21%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   53.59%   53.29%   -0.31%     
==========================================
  Files          54       54              
  Lines        3502     3522      +20     
  Branches      370      370              
==========================================
  Hits         1877     1877              
- Misses       1268     1288      +20     
  Partials      357      357              
Impacted Files Coverage Δ
src/build.ts 45.03% <65.21%> (-3.73%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 13:08 codecov[bot]