nitro icon indicating copy to clipboard operation
nitro copied to clipboard

fix(preset): add multiValueQueryStringParameters to aws preset

Open huang-julien opened this issue 1 year ago β€’ 1 comments

πŸ”— Linked issue

resolve #396

❓ Type of change

  • [ ] πŸ“– Documentation (updates to the documentation or readme)
  • [x] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [ ] πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR aims to add the multiValueQueryStringParameters from APIGatewayProxyEvent. Currently the request only retrieve the queries from the queryStringParameters, this don't allow us to have an array of query like /api?test=foo&test=bar&test=hello (this return only the last query -> { test: 'hello' }.

πŸ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

huang-julien avatar Aug 08 '22 15:08 huang-julien

Codecov Report

Merging #398 (710fdbc) into main (801bc28) will increase coverage by 0.49%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #398      +/-   ##
==========================================
+ Coverage   55.96%   56.45%   +0.49%     
==========================================
  Files          54       54              
  Lines        3472     3431      -41     
  Branches      364      363       -1     
==========================================
- Hits         1943     1937       -6     
+ Misses       1178     1144      -34     
+ Partials      351      350       -1     
Impacted Files Coverage Ξ”
src/rollup/plugins/handlers.ts 61.90% <ΓΈ> (+22.61%) :arrow_up:
src/imports.ts 95.34% <0.00%> (+0.11%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 08 '22 15:08 codecov[bot]