mkdist icon indicating copy to clipboard operation
mkdist copied to clipboard

Support multiple glob patterns

Open dwightjack opened this issue 2 years ago • 3 comments

This PR iterates over #21.

The globby library supports an array with multiple globs as its first argument, and mri already supports multiple inputs for a flag (--pattern=aaa --pattern=bbb --> pattern: ['aaa', 'bbb']).

Adding the ability to pass multiple patterns makes it easier to use negative patterns and create more complex filters.

On the documentation, I am not sure whether the [--pattern=glob [--pattern=more-glob]] signature is correct or if there is a clearer way to express the feature.

dwightjack avatar May 13 '22 01:05 dwightjack

Codecov Report

Merging #41 (c6206a0) into main (e10e549) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   96.85%   96.85%           
=======================================
  Files           6        6           
  Lines         127      127           
  Branches       36       36           
=======================================
  Hits          123      123           
  Misses          4        4           
Impacted Files Coverage Δ
src/make.ts 96.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e10e549...c6206a0. Read the comment docs.

codecov-commenter avatar May 13 '22 01:05 codecov-commenter

Hi folks!

I know you are busy working on the next release of Nuxt, so I am just checking in to know your opinion about this idea.

By the way, if you need help for the maintenance of this (and other) package(s), feel free to ping me 😃 .

dwightjack avatar Jun 28 '22 03:06 dwightjack

Hi folks!

I know you are busy working on the next release of Nuxt, so I am just checking in to know your opinion about this idea.

By the way, if you need help for the maintenance of this (and other) package(s), feel free to ping me 😃 .

Sorry, just checking about the status of this PR. Is there any blocker for it to be merged and released? Let me know if I can help in any way 😄

dwightjack avatar Oct 04 '22 03:10 dwightjack