magic-regexp icon indicating copy to clipboard operation
magic-regexp copied to clipboard

feat: add `orChar`/`from` chain for `charIn`/`charNotIn`

Open danielroe opened this issue 1 year ago • 4 comments

🔗 Linked issue

resolves https://github.com/unjs/magic-regexp/issues/397

❓ Type of change

  • [ ] 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] 🐞 Bug fix (a non-breaking change that fixes an issue)
  • [ ] 👌 Enhancement (improving an existing functionality like performance)
  • [x] ✨ New feature (a non-breaking change that adds functionality)
  • [ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This adds an implementation for creating custom ranges like [abcA-Z].

TODO:

  • [ ] add converter implementation to convert to this syntax
  • [ ] validate/review API

📝 Checklist

  • [ ] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

danielroe avatar Jun 04 '24 14:06 danielroe

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magic-regexp-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2025 1:22am

vercel[bot] avatar Jun 04 '24 14:06 vercel[bot]

Diagnostics Comparison:

Click to expand
Metric Previous New Status
Files 352 352 ± (0.00%)
Lines 136176 136227 ▲ (+0.04%)
Identifiers 144200 144386 ▲ (+0.13%)
Symbols 246224 248193 ▲ (+0.79%)
Types 50363 52292 ▲ (+3.69%)
Instantiations 605012 613876 ▲ (+1.44%)
Memory used 276359K 288249K ▲ (+4.12%)
I/O read 0.02s 0.02s ± (0.00%)
I/O write 0s 0s ± (0.00%)
Parse time 0.87s 0.87s ± (0.00%)
Bind time 0.35s 0.35s ± (0.00%)
Check time 1.94s 2.04s ± (+4.90%)
Emit time 0.09s 0.08s ± (-12.50%)
Total time 3.24s 3.33s ± (+2.70%)

github-actions[bot] avatar Jun 04 '24 14:06 github-actions[bot]

CodSpeed Performance Report

Merging #399 will not alter performance

Comparing feat/or-char-from (b7bc3e3) with main (4be3c53)

Summary

✅ 6 untouched benchmarks

codspeed-hq[bot] avatar Jun 04 '24 14:06 codspeed-hq[bot]

Diagnostics Comparison:

Click to expand
Metric Previous New Status
Files 352 352 ± (0.00%)
Lines 136176 136227 ▲ (+0.04%)
Identifiers 144200 144387 ▲ (+0.13%)
Symbols 246224 248193 ▲ (+0.79%)
Types 50363 52292 ▲ (+3.69%)
Instantiations 605012 613876 ▲ (+1.44%)
Memory used 273822K 282845K ▲ (+3.19%)
I/O read 0.03s 0.02s ▼ (-50.00%)
I/O write 0s 0s ± (0.00%)
Parse time 1.03s 0.89s ± (-15.73%)
Bind time 0.39s 0.35s ± (-11.43%)
Check time 2.22s 2.06s ± (-7.77%)
Emit time 0.09s 0.09s ± (0.00%)
Total time 3.73s 3.38s ▼ (-10.36%)

github-actions[bot] avatar Jun 04 '24 14:06 github-actions[bot]

Is this going to be undrafted some time soon?

favna avatar Jan 27 '25 14:01 favna

Diagnostics Comparison:

Click to expand
Metric Previous New Status
Files 356 356 ± (0.00%)
Lines 147704 147755 ▲ (+0.03%)
Identifiers 150594 150781 ▲ (+0.12%)
Symbols 252756 255380 ▲ (+1.03%)
Types 51231 53566 ▲ (+4.36%)
Instantiations 612217 622796 ▲ (+1.70%)
Memory used 283252K 289083K ▲ (+2.02%)
I/O read 0.03s 0.02s ▼ (-50.00%)
I/O write 0s 0s ± (0.00%)
Parse time 0.95s 0.94s ± (-1.06%)
Bind time 0.41s 0.42s ± (+2.38%)
Check time 2s 2.19s ± (+8.68%)
Emit time 0.1s 0.11s ± (+9.09%)
Total time 3.46s 3.65s ± (+5.21%)

github-actions[bot] avatar Apr 09 '25 01:04 github-actions[bot]