listhen icon indicating copy to clipboard operation
listhen copied to clipboard

feat: persist and reuse generated https certificates

Open Mastercuber opened this issue 1 year ago โ€ข 2 comments

๐Ÿ”— Linked issue

closes #132

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

In this PR a new flag (--https.reuse) is introduced to be able to reuse previosly autogenerated certificates, instead of generating them every time listhen is restarted.

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

Mastercuber avatar Nov 05 '23 20:11 Mastercuber

Codecov Report

Attention: Patch coverage is 52.54237% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 50.48%. Comparing base (d115045) to head (55cc0fd). Report is 14 commits behind head on main.

Files Patch % Lines
src/_cert.ts 57.69% 22 Missing :warning:
src/cli.ts 0.00% 6 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   49.42%   50.48%   +1.06%     
==========================================
  Files          17       17              
  Lines        1819     1844      +25     
  Branches      147      148       +1     
==========================================
+ Hits          899      931      +32     
+ Misses        915      908       -7     
  Partials        5        5              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 05 '23 21:11 codecov[bot]

@pi0 Is there something else needed for this to get merged?

gkkirilov avatar Jan 07 '24 11:01 gkkirilov