fix(node): v1 - hook calling order
Relates to https://github.com/unjs/h3/pull/756, https://github.com/unjs/h3/pull/789
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Please upload report for BASE (
v1@a15b8de). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@
## v1 #793 +/- ##
=====================================
Coverage ? 79.81%
=====================================
Files ? 54
Lines ? 5385
Branches ? 691
=====================================
Hits ? 4298
Misses ? 1068
Partials ? 19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi again.
v2 supports fine-grained control to handle errors (using global onError or new onError() middleware)
Your change seems reasonable, however, it makes a behavior change which might cause unwanted regressions for v1 users (and we are going soon to make it maintenance-only), so better not to risk IMO.
Cheers ❤️