giget
giget copied to clipboard
fix: correct gitlab repository path
๐ Linked issue
#107
โ Type of change
- [ ] ๐ Documentation (updates to the documentation, readme, or JSdoc annotations)
- [x] ๐ Bug fix (a non-breaking change that fixes an issue)
- [x] ๐ Enhancement (improving an existing functionality like performance)
- [ ] โจ New feature (a non-breaking change that adds functionality)
- [ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
- [ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
Gitlab supports nested subgroups, like https://gitlab.com/{groupName}/{subgroupName}/{repoName}
. Attempting to pull any subgroup would result in a 403 error. This pull request resolves the issue.
๐ Checklist
- [x] I have linked an issue or discussion.
- [ ] I have updated the documentation accordingly.
Codecov Report
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
81c9429
) 54.63% compared to head (14561ec
) 54.63%.
Files | Patch % | Lines |
---|---|---|
src/providers.ts | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #141 +/- ##
=======================================
Coverage 54.63% 54.63%
=======================================
Files 7 7
Lines 615 615
Branches 47 47
=======================================
Hits 336 336
Misses 278 278
Partials 1 1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi. Sorry for delay on this. I mainly wanted to double check if both with and without subgroups it works and didn't had a chance to make a testing gitlab structure yet. If you have some it can be helpful to speedup landing this ๐๐ผ
Hi @sl0wik . Thanks for that fix. It helps me a lot. To be compatible with the latest giget version v1.2.3 your fix need to be updated a little:
url: `${gitlab2}/${parsed.repo}${parsed.subdir}/tree/${parsed.ref}`,
tar: `${gitlab2}/${parsed.repo}${parsed.subdir}/-/archive/${parsed.ref}.tar.gz`,