giget icon indicating copy to clipboard operation
giget copied to clipboard

fix: correct gitlab repository path

Open sl0wik opened this issue 1 year ago โ€ข 3 comments

๐Ÿ”— Linked issue

#107

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [x] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Gitlab supports nested subgroups, like https://gitlab.com/{groupName}/{subgroupName}/{repoName}. Attempting to pull any subgroup would result in a 403 error. This pull request resolves the issue.

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [ ] I have updated the documentation accordingly.

sl0wik avatar Jan 10 '24 19:01 sl0wik

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (81c9429) 54.63% compared to head (14561ec) 54.63%.

Files Patch % Lines
src/providers.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #141   +/-   ##
=======================================
  Coverage   54.63%   54.63%           
=======================================
  Files           7        7           
  Lines         615      615           
  Branches       47       47           
=======================================
  Hits          336      336           
  Misses        278      278           
  Partials        1        1           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 10 '24 20:01 codecov[bot]

Hi. Sorry for delay on this. I mainly wanted to double check if both with and without subgroups it works and didn't had a chance to make a testing gitlab structure yet. If you have some it can be helpful to speedup landing this ๐Ÿ™๐Ÿผ

pi0 avatar Mar 21 '24 19:03 pi0

Hi @sl0wik . Thanks for that fix. It helps me a lot. To be compatible with the latest giget version v1.2.3 your fix need to be updated a little: url: `${gitlab2}/${parsed.repo}${parsed.subdir}/tree/${parsed.ref}`, tar: `${gitlab2}/${parsed.repo}${parsed.subdir}/-/archive/${parsed.ref}.tar.gz`,

kovaletsyurii-hue avatar May 02 '24 07:05 kovaletsyurii-hue