two subset defaults.

[shtse8]

interface UploadOptions<T extends StorageList> {
  storeKey?: keyof T
  id?: string
}

interface UrlUploadOptions {
  lazy?: boolean
}

async uploadByUrl(url: string, options?: UploadOptions<typeof this.storages> & UrlUploadOptions): Promise<Image> {
  const opts = defu(options ?? {}, this.defaultUploadOptions, this.defaultUrlUploadOptions)
 // ...
}

Type Error:

TS2559: Type 'UrlUploadOptions' has no properties in common with type 'UploadOptions '.

It's because of the type

<Source extends Input, Defaults extends Input>(source: Source, ...defaults: Defaults[]): MergeObjects<Source, Defaults>;

Could we change it to Partial<Defaults>?

Currently I can merge two defaults into one to apply.

const opts = defu(options ?? {}, { ...this.defaultUploadOptions, ...this.defaultUrlUploadOptions })

but, it needs merging before applying. or call defu twice... sounds stupid.

[pi0]

/cc @danielroe

[danielroe]

defu already accepts partials of the desired type. I think the issue in your case is due to the untyped {} you are passing as the first argument, and I think you can resolve in your own project with:

+   // for readability
+   type Options = UploadOptions<typeof this.storages> & UrlUploadOptions

-   const opts = defu(options ?? {}, this.defaultUploadOptions, this.defaultUrlUploadOptions)
+   const opts = defu(options ?? {} as Partial<Options>, this.defaultUploadOptions, this.defaultUrlUploadOptions)

Let me know if I've misunderstood what you are asking for.