db0 icon indicating copy to clipboard operation
db0 copied to clipboard

feat: MSSQL connector

Open nick-w-nick opened this issue 1 year ago โ€ข 4 comments

๐Ÿ”— Linked issue resolves #120

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description In this PR I've implemented an MSSQL connector utilizing the tedious library.

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [x] I have updated the documentation accordingly.

nick-w-nick avatar Nov 09 '24 06:11 nick-w-nick

Codecov Report

Attention: Patch coverage is 35.15152% with 107 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@11c2bf2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/connectors/mssql.ts 35.62% 103 Missing :warning:
scripts/gen-connectors.ts 0.00% 4 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #121   +/-   ##
=======================================
  Coverage        ?   42.87%           
=======================================
  Files           ?       23           
  Lines           ?     1024           
  Branches        ?      106           
=======================================
  Hits            ?      439           
  Misses          ?      581           
  Partials        ?        4           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 14 '24 00:11 codecov[bot]

Hi @nick-w-nick, thanks for your work on this. sorry it might take me longer to be able to properly review and test this PR but I have not forgotten.

pi0 avatar Jan 27 '25 16:01 pi0

@pi0 I've gone ahead and updated the PR to use the new typings/export logic that had been merged in previously. All merge conflicts should be the resolved and the tests should now pass once more.

If you need it to test locally, this is the Docker image I am using for MSSQL as it is the most compatible across platforms: https://hub.docker.com/r/microsoft/azure-sql-edge

These are the environment variables required (also shown in the .env.example file)

MSSQL_HOST=localhost
MSSQL_PORT=1433
MSSQL_USERNAME=sa # default mssql username
MSSQL_PASSWORD=password
MSSQL_DB_NAME=test_db

Let me know if you need any additional assistance!

nick-w-nick avatar Jan 28 '25 19:01 nick-w-nick

Hey guys,

just wondering what the status is on this PR? Is it planned to get this merged as there was no update since 4 month. Know it is still in review, not sure if there is a way to somehow support? Thanks for the amazing work. Would like to see it in the code base

sbruegel avatar May 27 '25 12:05 sbruegel