crossws
crossws copied to clipboard
fix: should not serailize binary messages
๐ Linked issue
closes #37
โ Type of change
- [ ] ๐ Documentation (updates to the documentation, readme, or JSdoc annotations)
- [x] ๐ Bug fix (a non-breaking change that fixes an issue)
- [ ] ๐ Enhancement (improving an existing functionality like performance)
- [ ] โจ New feature (a non-breaking change that adds functionality)
- [ ] ๐งน Chore (updates to the build process or auxiliary tools and libraries)
- [ ] โ ๏ธ Breaking change (fix or feature that would cause existing functionality to change)
๐ Description
๐ Checklist
- [x] I have linked an issue or discussion.
- [x] I have updated the documentation accordingly.
Hey, Not sure if you finished working on this PR yet, but I just wanted to let you know that, even though this PR looks necessary in order to fix #37, it doesn't fix it. You might not want to close the issue with this PR :/
It should be easy to "fix", so I might propose a PR once I know it should be fixed in crossws (I was waiting for the maintainers' feedback on my issue before doing any work).
Thanks for your work !