changelogen icon indicating copy to clipboard operation
changelogen copied to clipboard

feat: add skipAuthors (boolean) option

Open kleinpetr opened this issue 1 year ago โ€ข 2 comments

Resolves #174

โ“ Type of change

  • [x] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [x] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

the new option --skipAuthors to avoid Contributors section

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [x] I have updated the documentation accordingly.

kleinpetr avatar Mar 17 '24 19:03 kleinpetr

@pi0 could anyone check this small PR?

kleinpetr avatar Mar 25 '24 10:03 kleinpetr

https://github.com/pi0/tired-maintainer

pi0 avatar Mar 25 '24 11:03 pi0

@PKief don't understand why but all the tests pass locally but not in the ci

kleinpetr avatar Nov 13 '24 13:11 kleinpetr

@kleinpetr it is a snapshot mismatch, please don't worry about it will check before merge. And again sorry this PR got delayed this much I had been busy on so many other projects.

pi0 avatar Nov 13 '24 13:11 pi0

@PKief don't understand why but all the tests pass locally but not in the ci

Something looks a little weird, because the CI expects this line to be part of the snapshot:

image

Locally, it's working fine for me as well.

PKief avatar Nov 13 '24 13:11 PKief

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 45.55%. Comparing base (0914fd7) to head (e01b613). Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/default.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #183       +/-   ##
===========================================
- Coverage   69.10%   45.55%   -23.55%     
===========================================
  Files           9       12        +3     
  Lines         916      957       +41     
  Branches       85      102       +17     
===========================================
- Hits          633      436      -197     
- Misses        283      518      +235     
- Partials        0        3        +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 26 '25 10:02 codecov[bot]