changelogen icon indicating copy to clipboard operation
changelogen copied to clipboard

feat: add the ability to create a PR with the incoming changelog

Open Barbapapazes opened this issue 2 years ago • 4 comments

Hello,

This PR follows https://github.com/nuxt/nuxt/issues/20675.

It's a first draft because I'm not sure on how we must handle the PR. In fact, have we to reuse code from the release, create a new condition or a new command?

Also, we need to:

  • [ ] Add the base branch into the config file (or maybe there is already a base branch and I don't see it)
  • [ ] Add a way for the user to provide a template for the changelog header
  • [ ] Add a way to customize the branch name
  • [ ] Add a way to change the user that create the commit (name and email)

Support for workspace will coming after #18 is finished.

Barbapapazes avatar May 08 '23 13:05 Barbapapazes

I think for first step, we can introduce a updateGithubIssue utility, it can search for github issues and update first with v{x.y.z} title or create a new one. Dealing with branches for PR can be next step :)

pi0 avatar May 08 '23 14:05 pi0

I think for first step, we can introduce a updateGithubIssue utility, it can search for github issues and update first with v{x.y.z} title or create a new one. Dealing with branches for PR can be next step :)

Ok, if I understand well, you can to have a command to add changelog to an issue and another one to add changelog to a PR which also update package version?

Barbapapazes avatar May 09 '23 11:05 Barbapapazes

@pi0 can you tell me if direction is correct before I continue to create code?

Still wip but I want to be sure that I'm not doing something wrong!

Barbapapazes avatar May 09 '23 12:05 Barbapapazes

Hello @danielroe, could you please review this PR when you have a bit of time? Thanks a lot!

Barbapapazes avatar Jul 04 '23 08:07 Barbapapazes