anycast_healthchecker icon indicating copy to clipboard operation
anycast_healthchecker copied to clipboard

Removed the need for dummy IP prefix.

Open Pimoz opened this issue 4 years ago • 3 comments

List with no elements can be initialized as LIST = false; in BIRD and this is a correct syntax.

Pimoz avatar May 10 '21 14:05 Pimoz

Hi @Pimoz,

Firstly, let me apologize for the very late response, but life has been very difficult the past period.

I am OK with this change but it is not backwards compatible, so it will break current installations which utilize older version of Bird. You could add a logic to the check if dummy_ip_prefix setting is present and act accordingly. What do you think?

Thanks a lot for your interested in the project and the time you spent to prepare this PR, Pavlos

unixsurfer avatar Jun 11 '21 08:06 unixsurfer

No problem, we all know how life can be :)

Yes you are right. I will prepare a fix so everything will be backwards compatible.

This project is great btw. Just what I needed.

Pimoz avatar Jun 11 '21 09:06 Pimoz

@Pimoz that sounds like a great improvement, I was wondering if you ended up writing that fix. Thanks

XioNoX avatar Aug 03 '23 13:08 XioNoX