acme-client icon indicating copy to clipboard operation
acme-client copied to clipboard

Published 20 hours ago • verified publisher icon unixcharles

Add EAB support for ssl.com & zerossl.com

Open scrazy77 opened this issue 3 years ago • 2 comments

Add EAB support for ssl.com & zerossl.com. The code is based on https://github.com/unixcharles/acme-client/pull/201 and implement the eab reqeust to ssl.com & zerossl.com. I've tested it and can get certificates.

scrazy77 avatar Oct 13 '21 04:10 scrazy77

Thanks! I'll need to find time to write automated test but hopefully soon.

unixcharles avatar Oct 27 '21 20:10 unixcharles

Hey folks. any update on this one? i'm currently working on adding this in on my application but it'd be great to have this in the gem proper 😄

jamesooo avatar Jul 12 '22 16:07 jamesooo

👋 Hi,

Is there any way we could help to move this forward @unixcharles ? I see it's pending on tests being added, I don't mind writing the tests for this feature if needed.

This would also add support for digicert as it requires EAB for authentication. There is another PR adding the same feature: https://github.com/unixcharles/acme-client/pull/219

Shaeli avatar Jan 25 '23 10:01 Shaeli

Never got around to write test for it.

I'm not a zerossl user so its a bit difficult for me to test. Normally I test against boulder but I have a digicert account so that might be an option to write some tests. I'll give it a try over the weekend.

If one of you is willing to add test with VCR recording I would be ready to merge directly. I like the implementation.

unixcharles avatar Jan 31 '23 17:01 unixcharles

https://github.com/unixcharles/acme-client/pull/221

unixcharles avatar Jan 31 '23 23:01 unixcharles

The feature is available in 2.0.13. Let me know if that work for you @scrazy77

unixcharles avatar Feb 01 '23 20:02 unixcharles

thanks , I'll test it this week!

scrazy77 avatar Feb 08 '23 07:02 scrazy77