universitas.no icon indicating copy to clipboard operation
universitas.no copied to clipboard

Published 20 hours ago • verified publisher icon universitas

use rapidfuzz instead of fuzzywuzzy

Open maxbachmann opened this issue 4 years ago • 3 comments

FuzzyWuzzy is GPLv2 licensed which would force you to licence the whole project under GPLv2. For this reason this Pullrequest replaces FuzzyWuzzy with rapidfuzz which is implementing the same algorithm but is based on a version of fuzzywuzzy that was MIT Licensed. Rapidfuzz is:

  • Mit licensed so it can be used with the license used by this project
  • Is faster than FuzzyWuzzy

Apparently I did something wrong somewhere since it does not install rapidfuzz in travis

maxbachmann avatar Mar 29 '20 13:03 maxbachmann

@maxbachmann Yeah. The CI pipeline for this repo is a bit complicated. The python dependencies are built in a docker image on docker hub. But that doesn't work for pull requests. That's why the Travis build doesn't work properly here.

haakenlid avatar Mar 30 '20 21:03 haakenlid

rapidfuzz looks good, @maxbachmann. Thanks! I should do a manual test of this before merging, and also update some other pip dependencies at the same time, so I'll come back to this later.

haakenlid avatar Mar 30 '20 21:03 haakenlid

@haakenlid is there still interest in this? otherwise feel free to close this PR.

maxbachmann avatar Mar 09 '21 22:03 maxbachmann