html: parse javascript broken by php

[jafl]

trafficstars

The html parser needs to be able to use php as a guest parser.

[codecov[bot]]

Codecov Report

Base: 82.80% // Head: 82.81% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (b0ac451) compared to base (5dc6ad1). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3490      +/-   ##
==========================================
+ Coverage   82.80%   82.81%   +0.01%     
==========================================
  Files         222      222              
  Lines       53757    53801      +44     
==========================================
+ Hits        44511    44555      +44     
  Misses       9246     9246              

Impacted Files	Coverage Δ
main/promise.c	100.00% <100.00%> (ø)
parsers/html.c	99.33% <100.00%> (+0.07%)	:arrow_up:
parsers/php.c	98.02% <100.00%> (+0.01%)	:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[masatake]

(I'm working on #3491).

[masatake]

Could you rebase this pull request on the latest master?

[masatake]

Instead of introducing the new test case, how about extending parser-php.r/run-guest.d/ ?

[jafl]

@masatake The difference between this and your previous commit is that there is <?php ... ?> in the middle of the JavaScript block. Without my change, the functions in the JavaScript block are not tagged.

[masatake]

Looks good for me. Thank you.

[masatake]

Do you like this crazy mechanism for stacking parsers?

More crazy items can be found in https://github.com/universal-ctags/ctags/issues/1577 . When the JavaScript parser supports destructing binding, I will work on supporting VUE again.

[masatake]

@jafl don't you merge this?

[jafl]

@masatake I thought you were working on a different solution to this issue?

[masatake]

@masatake I thought you were working on a different solution to this issue?

Sorry for making you be confused. I will work on the extra solution after you merge this pull request. So I would like you to merge this pull request if you are o.k.

[masatake]

Thank you!