ctags icon indicating copy to clipboard operation
ctags copied to clipboard

GitHub Actions: migrate ubuntu environment from 18.04 to 22.04

Open leleliu008 opened this issue 2 years ago • 4 comments

ubuntu-18.04 Actions runner image is deprecated since 2022-08-08 ubuntu-22.04 Actions runner image is available since 2022-08-08

Reference: https://github.com/actions/runner-images/issues/6002 https://github.com/actions/runner-images/issues/5998

Signed-off-by: leleliu008 [email protected]

leleliu008 avatar Aug 10 '22 06:08 leleliu008

A strange error is reported. I will inspect the error.

masatake avatar Aug 11 '22 09:08 masatake

error is caused by valgrind check.

https://github.com/universal-ctags/ctags/blob/master/Tmain/optscript.d/run.sh#L23

~/tmp/ctags/Tmain/optscript.d/string.valgrind.tmp:

==3327885== Memcheck, a memory error detector
==3327885== Copyright (C) 2002-2017, and GNU GPL'd, by Julian Seward et al. 
==3327885== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3327885== Command: /home/leleliu008/tmp/ctags/./optscript string.ps
==3327885== Parent PID: 3327202
==3327885== 
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x1b
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x25
### unhandled dwarf2 abbrev form code 0x1b
==3327885== Valgrind: debuginfo reader: ensure_valid failed:
==3327885== Valgrind:   during call to ML_(img_get)
==3327885== Valgrind:   request for range [68080284, +4) exceeds
==3327885== Valgrind:   valid image size of 8251312 for image:
==3327885== Valgrind:   "/home/leleliu008/tmp/ctags/optscript"
==3327885== 
==3327885== Valgrind: debuginfo reader: Possibly corrupted debuginfo file.
==3327885== Valgrind: I can't recover.  Giving up.  Sorry.
==3327885==

leleliu008 avatar Aug 11 '22 17:08 leleliu008

It seems that the latest clang version(clang14) has bugs, compile with gcc works well.

https://forum.manjaro.org/t/valgrind-fails-possibly-corrupted-debuginfo-file/118156

leleliu008 avatar Aug 11 '22 19:08 leleliu008

@leleliu008 thank you. How about changes like:

diff --git a/.github/workflows/testing-gnulinux.yml b/.github/workflows/testing-gnulinux.yml
index 2cfce7385..ecb1cb4d4 100644
--- a/.github/workflows/testing-gnulinux.yml
+++ b/.github/workflows/testing-gnulinux.yml
@@ -33,7 +33,14 @@ jobs:
     - name: update package information
       run: sudo apt-get -y -o APT::Immediate-Configure=false update
     - name: install tools and libraries
-      run: sudo apt-get -y -o APT::Immediate-Configure=false install valgrind pkg-config automake bash libjansson-dev libyaml-dev libseccomp-dev libxml2-dev gdb python3-docutils libpcre2-dev
+      run: sudo apt-get -y -o APT::Immediate-Configure=false install pkg-config automake bash libjansson-dev libyaml-dev libseccomp-dev libxml2-dev gdb python3-docutils libpcre2-dev
+    - name: install valgrind
+      if: matrix.compiler == 'clang' && matrix.os == 'ubuntu-22.04'
+      # valgrind doesn't work well with an executable built with clang 14.
+      # https://forum.manjaro.org/t/valgrind-fails-possibly-corrupted-debuginfo-file/118156
+      run: |
+        type clang > /dev/null && clang --version | head -1 | grep -q 14 \
+        || sudo apt-get -y -o APT::Immediate-Configure=false install valgrind
     - name: install rubygems and lcov
       if: matrix.compiler == 'gcc' && matrix.os == 'ubuntu-20.04'
       #run: sudo apt-get -y -o APT::Immediate-Configure=false install rubygems lcov

masatake avatar Aug 13 '22 19:08 masatake

Codecov Report

Merging #3455 (feb2186) into master (d14f055) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3455   +/-   ##
=======================================
  Coverage   83.32%   83.32%           
=======================================
  Files         219      219           
  Lines       52745    52745           
=======================================
  Hits        43949    43949           
  Misses       8796     8796           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 14 '22 06:08 codecov[bot]