ctags icon indicating copy to clipboard operation
ctags copied to clipboard

LdScript: using cppGetc() in wrong ways

Open masatake opened this issue 3 years ago • 2 comments

In many areas, the parser assumes values returned from cppGetc() are in the range of unsigned char, [0, 0xff]. An overhaul is needed.


Can I pass the value returned from cppGetc() to isspace directly? This question is applicable to ld-script and cxx.

Originally posted by @masatake in https://github.com/universal-ctags/ctags/pull/3444#discussion_r926929752

masatake avatar Jul 22 '22 21:07 masatake

See https://github.com/universal-ctags/ctags/pull/3690/commits/2cab33c5b8cacd2aeedcf4f8af5fe13ea68a561b .

masatake avatar May 15 '23 17:05 masatake

This can be applicable to asm.c

masatake avatar May 15 '23 17:05 masatake

[yamato@dev64]~/var/ctags-github% cat /tmp/input.lds 
0""
[yamato@dev64]~/var/ctags-github%  ./ctags /tmp/input.lds
ctags: ./main/vstring.h:110: vStringPutImpl: Assertion `c >= 0 && c <= 0xff' failed.
ctags: ./main/vstring.h:110: parsing /tmp/input.lds:1 as LdScript
zsh: IOT instruction (core dumped)  ./ctags /tmp/input.lds

masatake avatar Jul 25 '23 15:07 masatake