ctags icon indicating copy to clipboard operation
ctags copied to clipboard

main: delay reporing "Language already defined" fatal error till parsing starts

Open masatake opened this issue 4 years ago • 3 comments

Close #2935 again.

The original version of this pull request was merged and reverted because a segmentation fault is detected on AppVeyor.

Newly introduced vStringNewPrintf and vStringNewVPrintf trigger a bug in vStringNCatS. This pull request includes a fix for the bug.

masatake avatar May 05 '21 09:05 masatake

The segmentation faults are still reproduced on 32bit platforms.

masatake avatar May 05 '21 12:05 masatake

The bug is related to 646e26b7468970e18293d6cd0306a5482850a1ff.

masatake avatar May 05 '21 14:05 masatake

Codecov Report

Patch coverage: 68.88% and project coverage change: +4.37 :tada:

Comparison is base (2058211) 83.01% compared to head (8070412) 87.39%.

:exclamation: Current head 8070412 differs from pull request most recent head 1fc99a8. Consider uploading reports for the commit 1fc99a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3004      +/-   ##
==========================================
+ Coverage   83.01%   87.39%   +4.37%     
==========================================
  Files         227      199      -28     
  Lines       55128    47464    -7664     
==========================================
- Hits        45766    41481    -4285     
+ Misses       9362     5983    -3379     
Impacted Files Coverage Δ
main/vstring.h 100.00% <ø> (ø)
main/vstring.c 91.82% <61.90%> (-3.49%) :arrow_down:
main/error.c 90.47% <72.72%> (-9.53%) :arrow_down:
main/options.c 84.03% <100.00%> (+0.17%) :arrow_up:
main/parse.c 95.89% <100.00%> (+0.33%) :arrow_up:

... and 156 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar May 05 '21 15:05 codecov[bot]

after adding #include <stdarg.h> to main/vstring.h, the NetBSD and OpenBSD GitHub Actions workflow error will be missing.

It seems that the macOS GitHub Actions workflow error is caused by GitHub Actions Team, not a issue from HomeBrew. Reference, I think it will be fixed later.

leleliu008 avatar Jul 02 '23 03:07 leleliu008

@leleliu008 thank you.

The failure on "Environment: compiler=msvc, ARCH=x64" on Appveyor implies something critical bug. I should inspect the failure more. However, for making a new release, the change I illustrated in https://github.com/universal-ctags/ctags/issues/2935#issuecomment-1568998935 may be enough.

masatake avatar Jul 03 '23 02:07 masatake

~Surprisingly https://github.com/universal-ctags/ctags/issues/2935#issuecomment-1568998935 doesn't work at all. I must find another solution.~

As far as putting --version at the beginning of the command line, https://github.com/universal-ctags/ctags/issues/2935#issuecomment-1568998935 works fine.

masatake avatar Jul 03 '23 03:07 masatake

I'll make a pull request based on https://github.com/universal-ctags/ctags/issues/2935#issuecomment-1568998935 for closing #2935.

masatake avatar Jul 03 '23 09:07 masatake